From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v6 1/2] fiber: set diagnostics at madvise/mprotect failure
Date: Fri, 14 Feb 2020 00:26:09 +0100 [thread overview]
Message-ID: <6e0f734a-0415-8abc-8301-759a3135da12@tarantool.org> (raw)
In-Reply-To: <20200213081950.GM21061@uranus>
>>> diff --git a/test/unit/fiber_stack.cc b/test/unit/fiber_stack.cc
>>> new file mode 100644
>>> index 000000000..de7fe90e3
>>> --- /dev/null
>>> +++ b/test/unit/fiber_stack.cc
>>
>> 4. Do you need C++ here?
>
> The C++ was choosen because we already have fiber_XXX.cc tests
> so I simply tried to follow.
>
>> 5. I would call it fiber_errinj.c. In future we may want to
>> add more tests here, which use error injections. Up to you.
>
> From one point of view having one big test which would cover
> various aspects of tarantool might help discovering unexpectedly
> connected bugs.
In case of unit tests it is rather about reducing code duplication.
Because any fiber unit test on C includes the same headers, does
the same preparations in main(), may need some common utilities.
next prev parent reply other threads:[~2020-02-13 23:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 12:31 [Tarantool-patches] [PATCH v6 0/2] fiber: Handle stack madvise/mprotect errors Cyrill Gorcunov
2020-02-06 12:31 ` [Tarantool-patches] [PATCH v6 1/2] fiber: set diagnostics at madvise/mprotect failure Cyrill Gorcunov
2020-02-13 0:08 ` Vladislav Shpilevoy
2020-02-13 8:19 ` Cyrill Gorcunov
2020-02-13 23:26 ` Vladislav Shpilevoy [this message]
2020-02-14 7:56 ` Cyrill Gorcunov
2020-02-06 12:31 ` [Tarantool-patches] [PATCH v6 2/2] fiber: leak slab if unable to bring prots back Cyrill Gorcunov
2020-02-13 0:08 ` Vladislav Shpilevoy
2020-02-13 8:20 ` Cyrill Gorcunov
2020-02-09 17:39 ` [Tarantool-patches] [PATCH v6 0/2] fiber: Handle stack madvise/mprotect errors Vladislav Shpilevoy
2020-02-09 18:34 ` Cyrill Gorcunov
2020-02-13 0:07 ` Vladislav Shpilevoy
2020-02-13 7:16 ` Cyrill Gorcunov
2020-02-20 19:25 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e0f734a-0415-8abc-8301-759a3135da12@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v6 1/2] fiber: set diagnostics at madvise/mprotect failure' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox