Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@dev.tarantool.org, kostja.osipov@gmail.com
Subject: Re: [Tarantool-patches] [PATCH 1/2] replication: don't drop admin super privileges
Date: Tue, 5 Nov 2019 15:40:49 +0300	[thread overview]
Message-ID: <6cad59f7-4088-8691-2d1f-582bdaee5baf@tarantool.org> (raw)
In-Reply-To: <9f639a706f5dd6c6d9cf53f3ea5715c8c8cdddca.1572644348.git.v.shpilevoy@tarantool.org>

Sorry, found a bug in the test.

> diff --git a/test/replication/gh-4606-admin-creds.result b/test/replication/gh-4606-admin-creds.result
> new file mode 100644
> index 000000000..de882b34c
> --- /dev/null
> +++ b/test/replication/gh-4606-admin-creds.result
> @@ -0,0 +1,63 @@
> +test_run:switch('replica_auth')
> + | ---
> + | - true
> + | ...
> +i = box.info
> + | ---
> + | ...
> +i.replication[(i.id + 1) % 2].upstream.status == 'follow' or i

Actually, ID of the other instance is 'i.id % 2 + 1'.

I force pushed the fixed test.

  reply	other threads:[~2019-11-05 12:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-01 21:42 [Tarantool-patches] [PATCH 0/2] Admin universe access Vladislav Shpilevoy
2019-11-01 21:42 ` [Tarantool-patches] [PATCH 1/2] replication: don't drop admin super privileges Vladislav Shpilevoy
2019-11-05 12:40   ` Vladislav Shpilevoy [this message]
2019-11-05 18:20   ` Konstantin Osipov
2019-11-01 21:42 ` [Tarantool-patches] [PATCH 2/2] access: forbid to drop admin's universe access Vladislav Shpilevoy
2019-11-05 18:21   ` Konstantin Osipov
2019-11-12  9:37 ` [Tarantool-patches] [PATCH 0/2] Admin " Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6cad59f7-4088-8691-2d1f-582bdaee5baf@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=kostja.osipov@gmail.com \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 1/2] replication: don'\''t drop admin super privileges' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox