From: Alexander Turenko <alexander.turenko@tarantool.org> To: Kirill Yukhin <kyukhin@tarantool.org> Cc: Alexander Turenko <alexander.turenko@tarantool.org>, tarantool-patches@freelists.org Subject: [tarantool-patches] [PATCH] lua: remove digest.sha() and digest.sha_hex() Date: Tue, 19 Mar 2019 01:49:22 +0300 [thread overview] Message-ID: <6c81abf4ab1cca5f599153553a1b28f3fac89115.1552949246.git.alexander.turenko@tarantool.org> (raw) SHA-0 is considered weak for years and was removed in OpenSSL since 1.1.0. These Lua functions did not work since 15ed10e4, but give 'Digest method "sha" is not supported' error for any input. Removed them to don't confuse a user with a Tab completion. Follow up #1722. Fixes #4028. --- issue: https://github.com/tarantool/tarantool/issues/4028 branch: https://github.com/tarantool/tarantool/tree/Totktonada/gh-4028-remove-digest-sha-0 src/lua/crypto.lua | 2 +- src/lua/digest.lua | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/lua/crypto.lua b/src/lua/crypto.lua index b6b2d6540..e76370517 100644 --- a/src/lua/crypto.lua +++ b/src/lua/crypto.lua @@ -58,7 +58,7 @@ end local digests = {} for class, name in pairs({ md2 = 'MD2', md4 = 'MD4', md5 = 'MD5', - sha = 'SHA', sha1 = 'SHA1', sha224 = 'SHA224', + sha1 = 'SHA1', sha224 = 'SHA224', sha256 = 'SHA256', sha384 = 'SHA384', sha512 = 'SHA512', dss = 'DSS', dss1 = 'DSS1', mdc2 = 'MDC2', ripemd160 = 'RIPEMD160'}) do local digest = ffi.C.EVP_get_digestbyname(class) diff --git a/src/lua/digest.lua b/src/lua/digest.lua index 314ede1ed..8f199c0af 100644 --- a/src/lua/digest.lua +++ b/src/lua/digest.lua @@ -36,7 +36,6 @@ local BASE64_NOWRAP = 2 local BASE64_URLSAFE = 7 local digest_shortcuts = { - sha = 'SHA', sha224 = 'SHA224', sha256 = 'SHA256', sha384 = 'SHA384', -- 2.20.1
next reply other threads:[~2019-03-18 22:49 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-18 22:49 Alexander Turenko [this message] 2019-03-19 11:39 ` [tarantool-patches] " Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6c81abf4ab1cca5f599153553a1b28f3fac89115.1552949246.git.alexander.turenko@tarantool.org \ --to=alexander.turenko@tarantool.org \ --cc=kyukhin@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [tarantool-patches] [PATCH] lua: remove digest.sha() and digest.sha_hex()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox