Tarantool development patches archive
 help / color / mirror / Atom feed
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>,
	Alexander Turenko <alexander.turenko@tarantool.org>
Cc: Oleg Piskunov <o.piskunov@tarantool.org>,
	tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v1 2/2] test: remove skip condition of app-tap/pwd test
Date: Sun, 31 May 2020 08:09:42 +0300	[thread overview]
Message-ID: <6c05edf113965cdf0c6954476ed3928aa83a1e74.1590900417.git.avtikhon@tarantool.org> (raw)
In-Reply-To: <b3f158c1cfde5a693101a968285aba0cea6c12a1.1590900417.git.avtikhon@tarantool.org>
In-Reply-To: <b3f158c1cfde5a693101a968285aba0cea6c12a1.1590900417.git.avtikhon@tarantool.org>

During creating patch:

  e3d9d8c97edd39438cbc98fccac996e61ce4984c ("build: add CentOS 8 into CI / CD")

was found the issue:

  [001] app-tap/pwd.test.lua                                            [ fail ]
  [001] Test failed! Output from reject file app-tap/pwd.reject:
  [001] TAP version 13
  [001] 1..6
  [001] ok - checking user by id
  [001] ok - checking user by name
  [001] ok - checking group by id
  [001] ok - checking group by name
  [001]
  [001] Last 15 lines of Tarantool Log file [Instance "app_server"][/mnt/test/var/001_app-tap/pwd.test.lua.tarantool.log]:
  [001] tarantool: /lib64/libcurl.so.4: no version information available (required by tarantool)
  [001] builtin/pwd.lua:169: getpwall failed [errno 2]: No such file or directory

Currently it was tried to reproduce the issue, but all the attempts
didn't got the needed fail. After discussion of the issue decided to
close the current one as not the issue for the test and continue the
fixes for getpwall/getgrall functions within issue #5034.

Closes #4592
---

Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4592-enoent-pwd-full-ci
Issue: https://github.com/tarantool/tarantool/issues/4592

 test/app-tap/pwd.skipcond | 11 -----------
 1 file changed, 11 deletions(-)
 delete mode 100644 test/app-tap/pwd.skipcond

diff --git a/test/app-tap/pwd.skipcond b/test/app-tap/pwd.skipcond
deleted file mode 100644
index cf97461bc..000000000
--- a/test/app-tap/pwd.skipcond
+++ /dev/null
@@ -1,11 +0,0 @@
-import subprocess
-
-# Disable the test on CentOS 8 until gh-4592 will be resolved.
-try:
-    cmd = ['rpm', '--eval', '%{centos_ver}']
-    if subprocess.check_output(cmd).strip() == '8':
-        self.skip = 1
-except:
-    pass
-
-# vim: set ft=python:
-- 
2.17.1

  reply	other threads:[~2020-05-31  5:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-31  5:09 [Tarantool-patches] [PATCH v1 1/2] Correct error message at pwd.lua Alexander V. Tikhonov
2020-05-31  5:09 ` Alexander V. Tikhonov [this message]
2020-06-01  8:57   ` [Tarantool-patches] [PATCH v1 2/2] test: remove skip condition of app-tap/pwd test Sergey Bronnikov
2020-06-01 10:58   ` Alexander Turenko
2020-06-01  8:57 ` [Tarantool-patches] [PATCH v1 1/2] Correct error message at pwd.lua Sergey Bronnikov
2020-06-03 10:13 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c05edf113965cdf0c6954476ed3928aa83a1e74.1590900417.git.avtikhon@tarantool.org \
    --to=avtikhon@tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=o.piskunov@tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1 2/2] test: remove skip condition of app-tap/pwd test' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox