From: Serge Petrenko <sergepetrenko@tarantool.org> To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH 1/2] test: fix a typo in election_basic Date: Mon, 9 Nov 2020 12:01:01 +0300 [thread overview] Message-ID: <6becfe8b-47fa-690b-7c8c-8be88718ad46@tarantool.org> (raw) In-Reply-To: <91007b6ff6854cfbb49d83ecd9df172331c4cc99.1604706353.git.v.shpilevoy@tarantool.org> 07.11.2020 02:46, Vladislav Shpilevoy пишет: > The typo led to not resetting the election timeout to the default > value. It was left 1000, and as a result the next election tests > could work extremely long. Hi! Good catch, LGTM. > > Part of #5499 > --- > test/replication/election_basic.result | 2 +- > test/replication/election_basic.test.lua | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/test/replication/election_basic.result b/test/replication/election_basic.result > index 03917c7e4..4d7d33f2b 100644 > --- a/test/replication/election_basic.result > +++ b/test/replication/election_basic.result > @@ -6,7 +6,7 @@ test_run = require('test_run').new() > -- gh-1146: Raft protocol for automated leader election. > -- > > -old_election_timeout = box.cfg_election_timeout > +old_election_timeout = box.cfg.election_timeout > | --- > | ... > > diff --git a/test/replication/election_basic.test.lua b/test/replication/election_basic.test.lua > index 1b4bb8d27..821f73cea 100644 > --- a/test/replication/election_basic.test.lua > +++ b/test/replication/election_basic.test.lua > @@ -3,7 +3,7 @@ test_run = require('test_run').new() > -- gh-1146: Raft protocol for automated leader election. > -- > > -old_election_timeout = box.cfg_election_timeout > +old_election_timeout = box.cfg.election_timeout > > -- Election is turned off by default. > assert(box.cfg.election_mode == 'off') -- Serge Petrenko
next prev parent reply other threads:[~2020-11-09 9:01 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-06 23:46 [Tarantool-patches] [PATCH 0/2] Raft slow tests Vladislav Shpilevoy 2020-11-06 23:46 ` [Tarantool-patches] [PATCH 1/2] test: fix a typo in election_basic Vladislav Shpilevoy 2020-11-09 9:01 ` Serge Petrenko [this message] 2020-11-06 23:46 ` [Tarantool-patches] [PATCH 2/2] test: speed up election_qsync Vladislav Shpilevoy 2020-11-09 9:20 ` Serge Petrenko 2020-11-09 22:36 ` Vladislav Shpilevoy 2020-11-10 7:44 ` Serge Petrenko 2020-11-10 21:11 ` [Tarantool-patches] [PATCH 0/2] Raft slow tests Alexander V. Tikhonov 2020-11-10 22:05 ` Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6becfe8b-47fa-690b-7c8c-8be88718ad46@tarantool.org \ --to=sergepetrenko@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 1/2] test: fix a typo in election_basic' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox