From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergepetrenko@tarantool.org>
Received: from smtp43.i.mail.ru (smtp43.i.mail.ru [94.100.177.103])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id B89A0469719
 for <tarantool-patches@dev.tarantool.org>;
 Mon,  9 Nov 2020 12:01:02 +0300 (MSK)
References: <cover.1604706353.git.v.shpilevoy@tarantool.org>
 <91007b6ff6854cfbb49d83ecd9df172331c4cc99.1604706353.git.v.shpilevoy@tarantool.org>
From: Serge Petrenko <sergepetrenko@tarantool.org>
Message-ID: <6becfe8b-47fa-690b-7c8c-8be88718ad46@tarantool.org>
Date: Mon, 9 Nov 2020 12:01:01 +0300
MIME-Version: 1.0
In-Reply-To: <91007b6ff6854cfbb49d83ecd9df172331c4cc99.1604706353.git.v.shpilevoy@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [Tarantool-patches] [PATCH 1/2] test: fix a typo in
	election_basic
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org


07.11.2020 02:46, Vladislav Shpilevoy пишет:
> The typo led to not resetting the election timeout to the default
> value. It was left 1000, and as a result the next election tests
> could work extremely long.
Hi! Good catch, LGTM.
>
> Part of #5499
> ---
>   test/replication/election_basic.result   | 2 +-
>   test/replication/election_basic.test.lua | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/test/replication/election_basic.result b/test/replication/election_basic.result
> index 03917c7e4..4d7d33f2b 100644
> --- a/test/replication/election_basic.result
> +++ b/test/replication/election_basic.result
> @@ -6,7 +6,7 @@ test_run = require('test_run').new()
>   -- gh-1146: Raft protocol for automated leader election.
>   --
>   
> -old_election_timeout = box.cfg_election_timeout
> +old_election_timeout = box.cfg.election_timeout
>    | ---
>    | ...
>   
> diff --git a/test/replication/election_basic.test.lua b/test/replication/election_basic.test.lua
> index 1b4bb8d27..821f73cea 100644
> --- a/test/replication/election_basic.test.lua
> +++ b/test/replication/election_basic.test.lua
> @@ -3,7 +3,7 @@ test_run = require('test_run').new()
>   -- gh-1146: Raft protocol for automated leader election.
>   --
>   
> -old_election_timeout = box.cfg_election_timeout
> +old_election_timeout = box.cfg.election_timeout
>   
>   -- Election is turned off by default.
>   assert(box.cfg.election_mode == 'off')

-- 
Serge Petrenko