From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>,
tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v3 06/10] sql: move sqlite3DeleteTrigger to sql.h
Date: Thu, 14 Jun 2018 22:27:20 +0300 [thread overview]
Message-ID: <6be24107-ea9e-a646-69d3-792db53a1b92@tarantool.org> (raw)
In-Reply-To: <e6f3c4423f5dc6872143f91e31046b59d254b27d.1528997527.git.kshcherbatov@tarantool.org>
Thanks for the fixes!
I have pushed other review fixes as a separate commit. Please,
look and squash.
On 14/06/2018 20:32, Kirill Shcherbatov wrote:
> As we are going to port triggers to server, we need
> an instrument to release allocated memory in alter.cc.
>
> Part of #3273.
> ---
> src/box/sql.h | 9 +++++++++
> src/box/sql/callback.c | 7 +++----
> src/box/sql/sqliteInt.h | 3 +--
> src/box/sql/status.c | 6 +++---
> src/box/sql/tokenize.c | 2 +-
> src/box/sql/trigger.c | 30 +++++++++++++-----------------
> 6 files changed, 30 insertions(+), 27 deletions(-)
>
next prev parent reply other threads:[~2018-06-14 19:27 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 17:32 [tarantool-patches] [PATCH v3 00/10] sql: remove Triggers to server Kirill Shcherbatov
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 01/10] box: move db->pShchema init to sql_init Kirill Shcherbatov
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 10/10] sql: VDBE tests for trigger existence Kirill Shcherbatov
2018-06-14 19:27 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-15 16:21 ` Kirill Shcherbatov
2018-06-18 15:42 ` Vladislav Shpilevoy
2018-06-18 19:22 ` Kirill Shcherbatov
2018-06-19 10:24 ` Vladislav Shpilevoy
2018-06-19 15:12 ` Kirill Shcherbatov
2018-06-19 15:23 ` Vladislav Shpilevoy
2018-06-20 6:38 ` Kirill Shcherbatov
2018-06-20 8:10 ` Vladislav Shpilevoy
2018-06-20 8:24 ` Kirill Shcherbatov
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 02/10] sql: fix leak on CREATE TABLE and resolve self ref Kirill Shcherbatov
2018-06-14 22:46 ` [tarantool-patches] " n.pettik
2018-06-15 9:25 ` Vladislav Shpilevoy
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 03/10] sql: fix sql len in tarantoolSqlite3RenameTrigger Kirill Shcherbatov
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 04/10] box: port schema_find_id to C Kirill Shcherbatov
2018-06-14 19:27 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-14 22:46 ` n.pettik
2018-06-15 9:25 ` Vladislav Shpilevoy
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 05/10] sql: refactor sql_expr_compile to return AST Kirill Shcherbatov
2018-06-14 19:27 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-15 16:21 ` Kirill Shcherbatov
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 06/10] sql: move sqlite3DeleteTrigger to sql.h Kirill Shcherbatov
2018-06-14 19:27 ` Vladislav Shpilevoy [this message]
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 07/10] box: sort error codes in misc.test Kirill Shcherbatov
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 08/10] sql: new _trigger space format with space_id Kirill Shcherbatov
2018-06-14 19:27 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-15 16:21 ` Kirill Shcherbatov
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 09/10] sql: move Triggers to server Kirill Shcherbatov
2018-06-14 19:27 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-15 16:21 ` Kirill Shcherbatov
2018-06-18 15:42 ` Vladislav Shpilevoy
2018-06-18 19:22 ` Kirill Shcherbatov
2018-06-14 17:34 ` [tarantool-patches] Re: [PATCH v3 00/10] sql: remove " Kirill Shcherbatov
2018-06-20 8:35 ` Vladislav Shpilevoy
2018-06-28 15:47 ` n.pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6be24107-ea9e-a646-69d3-792db53a1b92@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v3 06/10] sql: move sqlite3DeleteTrigger to sql.h' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox