From: Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
tarantool-patches@dev.tarantool.org, gorcunov@gmail.com
Subject: Re: [Tarantool-patches] [PATCH 0/2] Swim misusage crashes
Date: Mon, 5 Apr 2021 12:05:55 +0300 [thread overview]
Message-ID: <6bc99d3f-cd16-a707-bd72-be65939f15ce@tarantool.org> (raw)
In-Reply-To: <cover.1617548717.git.v.shpilevoy@tarantool.org>
04.04.2021 18:06, Vladislav Shpilevoy пишет:
> The patchset fixes 2 crashes happened when SWIM API was misused.
>
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/swim-misusage-crashes-5951-5952
> Issue: https://github.com/tarantool/tarantool/issues/5951
> Issue: https://github.com/tarantool/tarantool/issues/5952
Hi! Thanks for the patches! LGTM.
> Vladislav Shpilevoy (2):
> swim: fix crash on bad member_by_uuid() call
> swim: check types in __serialize methods
>
> .../unreleased/swim-member_by_uuid-crash.md | 4 +
> changelogs/unreleased/swim-serialize-crash.md | 4 +
> src/lib/swim/swim.c | 2 +
> src/lua/swim.lua | 41 +++++--
> test/swim/gh-5952-swim-serialize.result | 101 ++++++++++++++++++
> test/swim/gh-5952-swim-serialize.test.lua | 33 ++++++
> test/swim/swim.result | 9 ++
> test/swim/swim.test.lua | 3 +
> test/unit/swim.c | 23 +++-
> test/unit/swim.result | 9 +-
> 10 files changed, 217 insertions(+), 12 deletions(-)
> create mode 100644 changelogs/unreleased/swim-member_by_uuid-crash.md
> create mode 100644 changelogs/unreleased/swim-serialize-crash.md
> create mode 100644 test/swim/gh-5952-swim-serialize.result
> create mode 100644 test/swim/gh-5952-swim-serialize.test.lua
>
--
Serge Petrenko
next prev parent reply other threads:[~2021-04-05 9:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-04 15:06 Vladislav Shpilevoy via Tarantool-patches
2021-04-04 15:06 ` [Tarantool-patches] [PATCH 1/2] swim: fix crash on bad member_by_uuid() call Vladislav Shpilevoy via Tarantool-patches
2021-04-04 15:06 ` [Tarantool-patches] [PATCH 2/2] swim: check types in __serialize methods Vladislav Shpilevoy via Tarantool-patches
2021-04-04 20:42 ` [Tarantool-patches] [PATCH 0/2] Swim misusage crashes Cyrill Gorcunov via Tarantool-patches
2021-04-05 9:05 ` Serge Petrenko via Tarantool-patches [this message]
2021-04-05 15:20 ` Kirill Yukhin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bc99d3f-cd16-a707-bd72-be65939f15ce@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/2] Swim misusage crashes' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox