From: Aleksandr Lyapunov <alyapunov@tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>,
tarantool-patches@dev.tarantool.org
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] lua: lua_field_inspect_table without pushcfunction
Date: Fri, 22 May 2020 14:48:58 +0300 [thread overview]
Message-ID: <6b1a3a5d-98b4-66fc-ec80-322c8f3531a0@tarantool.org> (raw)
In-Reply-To: <20200518093748.16825-1-skaplun@tarantool.org>
Thanks for the patch! I agree with Vlad's comments.
I have only one insignificant comment, see below.
The rest LGTM, but I'm not a Lua expert an could miss something.
On 5/18/20 12:37 PM, Sergey Kaplun wrote:
> + * Return values:
> + * -1 - error, set diag
> + * 0 - has serialize, success replace and have to finish
> + * 1 - hasn't serialize, need to process
I would say "doesn't have" or "hasn't got".
next prev parent reply other threads:[~2020-05-22 11:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 9:37 Sergey Kaplun
2020-05-18 21:52 ` Vladislav Shpilevoy
2020-05-19 10:29 ` Sergey Kaplun
2020-05-19 20:08 ` Vladislav Shpilevoy
2020-05-22 11:48 ` Aleksandr Lyapunov [this message]
2020-05-22 14:05 ` Alexander Turenko
2020-05-25 12:06 ` Sergey Kaplun
2020-06-02 0:19 ` Igor Munkin
2020-06-02 9:36 ` Igor Munkin
2020-06-10 12:15 ` Kirill Yukhin
2020-06-10 13:01 ` Igor Munkin
2020-06-10 13:39 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b1a3a5d-98b4-66fc-ec80-322c8f3531a0@tarantool.org \
--to=alyapunov@tarantool.org \
--cc=skaplun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] lua: lua_field_inspect_table without pushcfunction' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox