From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 2/3] box: make constraint operations transactional
Date: Mon, 30 Dec 2019 01:35:35 +0300 [thread overview]
Message-ID: <6ad7db18-665c-e599-a5f5-2da1a41af084@tarantool.org> (raw)
In-Reply-To: <20191229222839.GB44588@tarantool.org>
> Anyway, patch LGTM. This is second one approve so it can be pushed,
> but Sergos wrote that he is concerned about memory management
> during constraint id creation/drop. Sergos, did you find any
> issues, or we can push this patch?
I see sometimes, that random box tests hang. In logs I see
nothing, or mp_tuple_assert fail even before a test is started.
I tried to run with ASAN - found nothing. Did one another
self-review - nothing. Probably these were problems with luajit,
don't know. Can't reproduce anywhere.
next prev parent reply other threads:[~2019-12-29 22:35 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 18:34 [Tarantool-patches] [PATCH v2 0/2] Add constraint names hash table to space Roman Khabibov
2019-11-28 18:34 ` [Tarantool-patches] [PATCH v2 1/2] box: introduce constraint names hash table Roman Khabibov
2019-11-30 1:03 ` Vladislav Shpilevoy
2019-12-04 16:23 ` [Tarantool-patches] [PATCH v2 1/3] " Roman Khabibov
2019-12-07 16:34 ` Vladislav Shpilevoy
2019-12-10 12:48 ` Roman Khabibov
2019-11-28 18:34 ` [Tarantool-patches] [PATCH v2 2/2] sql: make constraint operations transactional Roman Khabibov
2019-11-29 7:38 ` Roman Khabibov
2019-11-30 1:03 ` Vladislav Shpilevoy
2019-12-04 16:23 ` [Tarantool-patches] [PATCH v2 2/3] " Roman Khabibov
2019-12-05 18:43 ` Roman Khabibov
2019-12-07 16:35 ` Vladislav Shpilevoy
2019-12-10 12:49 ` [Tarantool-patches] [PATCH v2 2/3] box: " Roman Khabibov
2019-12-15 22:26 ` Vladislav Shpilevoy
2019-12-17 15:03 ` Roman Khabibov
2019-12-28 0:18 ` Nikita Pettik
2019-12-28 11:07 ` Vladislav Shpilevoy
2019-12-29 0:07 ` Nikita Pettik
2019-12-29 15:51 ` Vladislav Shpilevoy
2019-12-29 22:28 ` Nikita Pettik
2019-12-29 22:35 ` Vladislav Shpilevoy [this message]
2019-12-30 11:12 ` Sergey Ostanevich
2019-12-30 12:05 ` Nikita Pettik
2019-12-21 20:54 ` Sergey Ostanevich
2019-12-22 14:59 ` Vladislav Shpilevoy
2019-12-24 12:06 ` Roman Khabibov
2019-11-30 1:03 ` [Tarantool-patches] [PATCH v2 0/2] Add constraint names hash table to space Vladislav Shpilevoy
2019-12-04 16:23 ` [Tarantool-patches] [PATCH v2 0/3] " Roman Khabibov
2019-12-07 16:34 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ad7db18-665c-e599-a5f5-2da1a41af084@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 2/3] box: make constraint operations transactional' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox