From: Vladimir Davydov <vdavydov.dev@gmail.com> To: kostja@tarantool.org Cc: tarantool-patches@freelists.org Subject: [PATCH 1/2] xlog: use ev_sleep instead of fiber_sleep for rate limiting Date: Tue, 29 May 2018 18:19:36 +0300 [thread overview] Message-ID: <6ac5f585085a3379daae90480c094412e67b4d2d.1527605229.git.vdavydov.dev@gmail.com> (raw) In-Reply-To: <cover.1527605229.git.vdavydov.dev@gmail.com> In-Reply-To: <cover.1527605229.git.vdavydov.dev@gmail.com> fiber_sleep() works only if the current thread was created with cord_costart(). Since vinyl worker threads don't need fibers, they are created with cord_start() and hence can't use fiber_sleep(). So to be able to limit rate of vinyl dump/compaction, we have to use ev_sleep() instead of fiber_sleep() in xlog. This is fine by other xlog writers, because they don't use fibers either, neither they should as xlogs are written without coio. Needed for #3220 --- src/box/xlog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/box/xlog.c b/src/box/xlog.c index af79e324..be7b3459 100644 --- a/src/box/xlog.c +++ b/src/box/xlog.c @@ -1090,7 +1090,7 @@ xlog_tx_write(struct xlog *log) throttle_time = (double)sync_len / log->rate_limit - (ev_monotonic_time() - log->sync_time); if (throttle_time > 0) - fiber_sleep(throttle_time); + ev_sleep(throttle_time); } /** sync data from cache to disk */ #ifdef HAVE_SYNC_FILE_RANGE -- 2.11.0
next prev parent reply other threads:[~2018-05-29 15:19 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-29 15:19 [PATCH 0/2] vinyl: allow to limit dump bandwidth Vladimir Davydov 2018-05-29 15:19 ` Vladimir Davydov [this message] 2018-06-01 17:52 ` [PATCH 1/2] xlog: use ev_sleep instead of fiber_sleep for rate limiting Konstantin Osipov 2018-06-04 9:51 ` Vladimir Davydov 2018-06-07 13:11 ` Konstantin Osipov 2018-05-29 15:19 ` [PATCH 2/2] vinyl: apply box.cfg.snap_io_rate_limit to dump/compaction Vladimir Davydov 2018-06-01 17:56 ` Konstantin Osipov 2018-06-04 9:55 ` Vladimir Davydov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6ac5f585085a3379daae90480c094412e67b4d2d.1527605229.git.vdavydov.dev@gmail.com \ --to=vdavydov.dev@gmail.com \ --cc=kostja@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [PATCH 1/2] xlog: use ev_sleep instead of fiber_sleep for rate limiting' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox