From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3 0/2] vinyl: rework upsert operation
Date: Thu, 15 Oct 2020 01:44:34 +0200 [thread overview]
Message-ID: <6a552158-6152-10b8-7f86-47aa71923ed4@tarantool.org> (raw)
In-Reply-To: <20201013101839.GA18306@tarantool.org>
Hi! Thanks for the patch!
The test looks fine, but hard to extend. I would better try to
organize a more extendible folder structure, like test/xlog/upgrade
does. With the current 'flat' structure we will have problems with
adding more tests for other versions in the future.
I see you already pushed it, so I am too late.
next prev parent reply other threads:[~2020-10-14 23:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-03 13:28 Nikita Pettik
2020-10-03 13:28 ` [Tarantool-patches] [PATCH v3 1/2] " Nikita Pettik
2020-10-06 22:12 ` Vladislav Shpilevoy
2020-10-09 15:06 ` Nikita Pettik
2020-10-13 19:00 ` Aleksandr Lyapunov
2020-10-14 0:15 ` Nikita Pettik
2020-10-14 8:58 ` Aleksandr Lyapunov
2020-10-14 10:42 ` Nikita Pettik
2020-10-14 11:47 ` Aleksandr Lyapunov
2020-10-15 0:36 ` Nikita Pettik
2020-10-03 13:28 ` [Tarantool-patches] [PATCH v3 2/2] vinyl: remove squash procedures from source code Nikita Pettik
2020-10-03 13:52 ` [Tarantool-patches] [PATCH v3 0/2] vinyl: rework upsert operation Nikita Pettik
2020-10-06 22:12 ` Vladislav Shpilevoy
2020-10-09 15:10 ` Nikita Pettik
2020-10-11 15:35 ` Vladislav Shpilevoy
2020-10-11 15:35 ` Vladislav Shpilevoy
2020-10-13 10:18 ` Nikita Pettik
2020-10-14 23:44 ` Vladislav Shpilevoy [this message]
2020-10-15 1:42 ` Nikita Pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a552158-6152-10b8-7f86-47aa71923ed4@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3 0/2] vinyl: rework upsert operation' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox