Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Imeev Mergen <imeevma@tarantool.org>, tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v2 1/1] sql: return last_insert_id via IPROTO
Date: Fri, 24 Aug 2018 13:05:13 +0300	[thread overview]
Message-ID: <69e57601-c71f-e403-c3cc-42a1a9225f22@tarantool.org> (raw)
In-Reply-To: <c3be15c8-7aa5-ee16-5690-b81e159bcf7d@tarantool.org>

Hi! Thanks for the fixes!

> commit 67d6dc1cc24a35786fab71222692672c4b01d4be
> Author: Mergen Imeev <imeevma@gmail.com>
> Date:   Tue Jul 31 16:43:38 2018 +0300
> 
>      sql: return last_insert_id via IPROTO
> 
>      After this patch client will get last_insert_id
>      as additional metadata when he executes some
>      statements.
> 
>      Part of #2618
> 
> diff --git a/src/box/sql/vdbeInt.h b/src/box/sql/vdbeInt.h
> index ce97f49..d768eee 100644
> --- a/src/box/sql/vdbeInt.h
> +++ b/src/box/sql/vdbeInt.h
> @@ -400,6 +400,11 @@ struct Vdbe {
>       VdbeFrame *pDelFrame;    /* List of frame objects to free on VM reset */
>       int nFrame;        /* Number of frames in pFrame list */
>       u32 expmask;        /* Binding to these vars invalidates VM */
> +    /*
> +     * True if field last_insert_id of current session was set
> +     * in current statement.
> +     */
> +    bool is_last_insert_id_set;

As I asked, this flag had to be moved to the flags section
of struct Vdbe, next to isPrepareV2, runOnlyOnce etc and occupy
1 bit. I did it for you this time in a separate commit on the
branch. Please, look and squash. And send the whole patchset
under v3 to Nikita P.

>       SubProgram *pProgram;    /* Linked list of all sub-programs used by VM */
>       AuxData *pAuxData;    /* Linked list of auxdata allocations */
>       /* Anonymous savepoint for aborts only */

      reply	other threads:[~2018-08-24 10:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-03 10:28 [tarantool-patches] " imeevma
2018-08-06 15:24 ` [tarantool-patches] " Vladislav Shpilevoy
2018-08-13 12:34   ` Imeev Mergen
2018-08-16 22:05     ` Vladislav Shpilevoy
2018-08-17 11:43       ` Imeev Mergen
2018-08-21 15:50         ` Vladislav Shpilevoy
2018-08-22 13:31           ` Imeev Mergen
2018-08-24 10:05             ` Vladislav Shpilevoy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69e57601-c71f-e403-c3cc-42a1a9225f22@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v2 1/1] sql: return last_insert_id via IPROTO' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox