Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alex Khatskevich <avkhatskevich@tarantool.org>
To: "n.pettik" <korablev@tarantool.org>, tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 3/3] sql: delete ignore_check_constraints pragma
Date: Thu, 4 Oct 2018 18:16:50 +0300	[thread overview]
Message-ID: <69d233c9-2911-f77b-e2d1-003e0239b625@tarantool.org> (raw)
In-Reply-To: <B1A46432-A7CE-48CB-A782-54C01C132E4D@tarantool.org>



On 02.10.2018 16:36, n.pettik wrote:
>> diff --git a/src/box/sql/sqliteInt.h b/src/box/sql/sqliteInt.h
>> index b2d527834..8883d37ad 100644
>> --- a/src/box/sql/sqliteInt.h
>> +++ b/src/box/sql/sqliteInt.h
>> @@ -1558,7 +1558,7 @@ struct sqlite3 {
>> #define SQLITE_WhereTrace     0x00008000       /* Debug info about optimizer's work */
>> #define SQLITE_VdbeListing    0x00000400	/* Debug listings of VDBE programs */
>> #define SQLITE_VdbeAddopTrace 0x00001000	/* Trace sqlite3VdbeAddOp() calls */
>> -#define SQLITE_IgnoreChecks   0x00002000	/* Do not enforce check constraints */
>> +/*                            0x00002000	   Free bit */
> The same: don’t do it. Lets simply delete this flag.
>
> The rest is OK.
Fixed

  reply	other threads:[~2018-10-04 15:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-02 10:48 [tarantool-patches] [PATCH 0/3] Delete foreign_keys and ignore_check_constraints pragmas AKhatskevich
2018-10-02 10:48 ` [tarantool-patches] [PATCH 1/3] sql: delete unused code AKhatskevich
2018-10-02 13:36   ` [tarantool-patches] " n.pettik
2018-10-04 15:16     ` Alex Khatskevich
2018-10-02 10:48 ` [tarantool-patches] [PATCH 2/3] sql: delete foreign_keys pragma AKhatskevich
2018-10-02 13:36   ` [tarantool-patches] " n.pettik
2018-10-04 15:16     ` Alex Khatskevich
2018-10-02 10:48 ` [tarantool-patches] [PATCH 3/3] sql: delete ignore_check_constraints pragma AKhatskevich
2018-10-02 13:36   ` [tarantool-patches] " n.pettik
2018-10-04 15:16     ` Alex Khatskevich [this message]
2018-10-04 16:27 ` [tarantool-patches] Re: [PATCH 0/3] Delete foreign_keys and ignore_check_constraints pragmas n.pettik
2018-10-05  7:15 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69d233c9-2911-f77b-e2d1-003e0239b625@tarantool.org \
    --to=avkhatskevich@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH 3/3] sql: delete ignore_check_constraints pragma' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox