* [Tarantool-patches] [PATCH luajit] ci: use Tarantool revision in integration workflow
@ 2025-05-30 12:12 Sergey Kaplun via Tarantool-patches
2025-06-02 11:02 ` Sergey Bronnikov via Tarantool-patches
0 siblings, 1 reply; 2+ messages in thread
From: Sergey Kaplun via Tarantool-patches @ 2025-05-30 12:12 UTC (permalink / raw)
To: Sergey Bronnikov; +Cc: tarantool-patches
This patch adds the specific Tarantool revision to be checked out in
callee workflows to avoid the inconsistency between the used workflow
and the version of Tarantool that ref we are using. This revision should
be updated during the bump of the workflow to the corresponding
long-term branch.
The patch left the <testing.yml> workflow intact since it uses a
different approach.
---
Branch: https://github.com/tarantool/luajit/tree/skaplun/tarantool-integration-branch-revision
.github/workflows/integration-tarantool-ecosystem.yml | 1 +
.github/workflows/integration-tarantool.yml | 11 +++++++++++
2 files changed, 12 insertions(+)
diff --git a/.github/workflows/integration-tarantool-ecosystem.yml b/.github/workflows/integration-tarantool-ecosystem.yml
index e303ae32..7b37bf86 100644
--- a/.github/workflows/integration-tarantool-ecosystem.yml
+++ b/.github/workflows/integration-tarantool-ecosystem.yml
@@ -43,3 +43,4 @@ jobs:
with:
submodule: luajit
revision: ${{ github.sha }}
+ tarantool_revision: master
diff --git a/.github/workflows/integration-tarantool.yml b/.github/workflows/integration-tarantool.yml
index 86182dd3..3d6deb6e 100644
--- a/.github/workflows/integration-tarantool.yml
+++ b/.github/workflows/integration-tarantool.yml
@@ -39,6 +39,7 @@ jobs:
with:
submodule: luajit
revision: ${{ github.sha }}
+ tarantool_revision: master
test-tarantool-debug:
name: debug
@@ -46,6 +47,7 @@ jobs:
with:
submodule: luajit
revision: ${{ github.sha }}
+ tarantool_revision: master
test-tarantool-debug_aarch64:
name: debug aarch64
@@ -53,6 +55,7 @@ jobs:
with:
submodule: luajit
revision: ${{ github.sha }}
+ tarantool_revision: master
test-tarantool-debug_asan_clang:
name: debug ASAN clang
@@ -60,6 +63,7 @@ jobs:
with:
submodule: luajit
revision: ${{ github.sha }}
+ tarantool_revision: master
test-tarantool-out_of_source:
name: out of source
@@ -67,6 +71,7 @@ jobs:
with:
submodule: luajit
revision: ${{ github.sha }}
+ tarantool_revision: master
test-tarantool-release:
name: release
@@ -74,6 +79,7 @@ jobs:
with:
submodule: luajit
revision: ${{ github.sha }}
+ tarantool_revision: master
test-tarantool-release_asan_clang:
name: release ASAN clang
@@ -81,6 +87,7 @@ jobs:
with:
submodule: luajit
revision: ${{ github.sha }}
+ tarantool_revision: master
test-tarantool-release_clang:
name: release clang
@@ -88,6 +95,7 @@ jobs:
with:
submodule: luajit
revision: ${{ github.sha }}
+ tarantool_revision: master
test-tarantool-release_lto:
name: release lto
@@ -95,6 +103,7 @@ jobs:
with:
submodule: luajit
revision: ${{ github.sha }}
+ tarantool_revision: master
test-tarantool-release_lto_clang:
name: release lto clang
@@ -102,6 +111,7 @@ jobs:
with:
submodule: luajit
revision: ${{ github.sha }}
+ tarantool_revision: master
test-tarantool-static_build:
name: static build
@@ -109,3 +119,4 @@ jobs:
with:
submodule: luajit
revision: ${{ github.sha }}
+ tarantool_revision: master
--
2.49.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Tarantool-patches] [PATCH luajit] ci: use Tarantool revision in integration workflow
2025-05-30 12:12 [Tarantool-patches] [PATCH luajit] ci: use Tarantool revision in integration workflow Sergey Kaplun via Tarantool-patches
@ 2025-06-02 11:02 ` Sergey Bronnikov via Tarantool-patches
0 siblings, 0 replies; 2+ messages in thread
From: Sergey Bronnikov via Tarantool-patches @ 2025-06-02 11:02 UTC (permalink / raw)
To: Sergey Kaplun; +Cc: tarantool-patches
[-- Attachment #1: Type: text/plain, Size: 3920 bytes --]
Hi, Sergey,
thanks for the patch!
LGTM and in a private conversation we decided to document
all steps required for managing branches in repository somewhere. I believe
it will help us to reduce a probability of mistakes like wrong
`tarantool_revision`
in release branch.
Sergey
On 5/30/25 15:12, Sergey Kaplun wrote:
> This patch adds the specific Tarantool revision to be checked out in
> callee workflows to avoid the inconsistency between the used workflow
> and the version of Tarantool that ref we are using. This revision should
> be updated during the bump of the workflow to the corresponding
> long-term branch.
>
> The patch left the <testing.yml> workflow intact since it uses a
> different approach.
> ---
>
> Branch:https://github.com/tarantool/luajit/tree/skaplun/tarantool-integration-branch-revision
>
> .github/workflows/integration-tarantool-ecosystem.yml | 1 +
> .github/workflows/integration-tarantool.yml | 11 +++++++++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/.github/workflows/integration-tarantool-ecosystem.yml b/.github/workflows/integration-tarantool-ecosystem.yml
> index e303ae32..7b37bf86 100644
> --- a/.github/workflows/integration-tarantool-ecosystem.yml
> +++ b/.github/workflows/integration-tarantool-ecosystem.yml
> @@ -43,3 +43,4 @@ jobs:
> with:
> submodule: luajit
> revision: ${{ github.sha }}
> + tarantool_revision: master
> diff --git a/.github/workflows/integration-tarantool.yml b/.github/workflows/integration-tarantool.yml
> index 86182dd3..3d6deb6e 100644
> --- a/.github/workflows/integration-tarantool.yml
> +++ b/.github/workflows/integration-tarantool.yml
> @@ -39,6 +39,7 @@ jobs:
> with:
> submodule: luajit
> revision: ${{ github.sha }}
> + tarantool_revision: master
>
> test-tarantool-debug:
> name: debug
> @@ -46,6 +47,7 @@ jobs:
> with:
> submodule: luajit
> revision: ${{ github.sha }}
> + tarantool_revision: master
>
> test-tarantool-debug_aarch64:
> name: debug aarch64
> @@ -53,6 +55,7 @@ jobs:
> with:
> submodule: luajit
> revision: ${{ github.sha }}
> + tarantool_revision: master
>
> test-tarantool-debug_asan_clang:
> name: debug ASAN clang
> @@ -60,6 +63,7 @@ jobs:
> with:
> submodule: luajit
> revision: ${{ github.sha }}
> + tarantool_revision: master
>
> test-tarantool-out_of_source:
> name: out of source
> @@ -67,6 +71,7 @@ jobs:
> with:
> submodule: luajit
> revision: ${{ github.sha }}
> + tarantool_revision: master
>
> test-tarantool-release:
> name: release
> @@ -74,6 +79,7 @@ jobs:
> with:
> submodule: luajit
> revision: ${{ github.sha }}
> + tarantool_revision: master
>
> test-tarantool-release_asan_clang:
> name: release ASAN clang
> @@ -81,6 +87,7 @@ jobs:
> with:
> submodule: luajit
> revision: ${{ github.sha }}
> + tarantool_revision: master
>
> test-tarantool-release_clang:
> name: release clang
> @@ -88,6 +95,7 @@ jobs:
> with:
> submodule: luajit
> revision: ${{ github.sha }}
> + tarantool_revision: master
>
> test-tarantool-release_lto:
> name: release lto
> @@ -95,6 +103,7 @@ jobs:
> with:
> submodule: luajit
> revision: ${{ github.sha }}
> + tarantool_revision: master
>
> test-tarantool-release_lto_clang:
> name: release lto clang
> @@ -102,6 +111,7 @@ jobs:
> with:
> submodule: luajit
> revision: ${{ github.sha }}
> + tarantool_revision: master
>
> test-tarantool-static_build:
> name: static build
> @@ -109,3 +119,4 @@ jobs:
> with:
> submodule: luajit
> revision: ${{ github.sha }}
> + tarantool_revision: master
[-- Attachment #2: Type: text/html, Size: 4297 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-02 11:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-30 12:12 [Tarantool-patches] [PATCH luajit] ci: use Tarantool revision in integration workflow Sergey Kaplun via Tarantool-patches
2025-06-02 11:02 ` Sergey Bronnikov via Tarantool-patches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox