From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
To: tarantool-patches@freelists.org,
Konstantin Osipov <kostja@tarantool.org>
Cc: vdavydov.dev@gmail.com
Subject: Re: [tarantool-patches] Re: [PATCH v3 3/7] box: move offset_slot init to tuple_format_add_field
Date: Fri, 5 Apr 2019 20:17:29 +0300 [thread overview]
Message-ID: <697b2d95-ed98-7b6e-09a9-621fcc2d6d9d@tarantool.org> (raw)
In-Reply-To: <20190404061944.GC1116@chai>
> I actually had a nit about this patch, I think 3 goto labels in
> such a simple function is a bit of an overkill - the code is
> harder to follow than necessary. I would ditch the 'cleanup'
> label, this would make the code simpler
Hi! Ok! I'll try to fix it with central patch that would touch this code region.
I will deal with the last patch fixes one week later, after vacation.
After investigation the causes of degradation on SQL tests conducted by Alexander,
I think we can not worry about initializing the field map and concentrate on featured
tuple_format_iterator.
next prev parent reply other threads:[~2019-04-05 17:17 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 15:49 [PATCH v3 0/7] box: introduce multikey indexes in memtx Kirill Shcherbatov
2019-04-02 15:49 ` [PATCH v3 1/7] box: cleanup key_def virtual extract_key setter Kirill Shcherbatov
2019-04-03 12:42 ` Vladimir Davydov
2019-04-03 16:22 ` [tarantool-patches] " Kirill Shcherbatov
2019-04-03 18:01 ` Vladimir Davydov
2019-04-02 15:49 ` [PATCH v3 2/7] lib: introduce a new json_path_multikey_offset helper Kirill Shcherbatov
2019-04-03 12:56 ` Vladimir Davydov
2019-04-03 16:22 ` [tarantool-patches] " Kirill Shcherbatov
2019-04-03 18:02 ` Vladimir Davydov
2019-04-04 6:17 ` Konstantin Osipov
2019-04-02 15:49 ` [PATCH v3 3/7] box: move offset_slot init to tuple_format_add_field Kirill Shcherbatov
2019-04-03 12:57 ` Vladimir Davydov
2019-04-03 18:02 ` Vladimir Davydov
2019-04-04 6:19 ` [tarantool-patches] " Konstantin Osipov
2019-04-05 17:17 ` Kirill Shcherbatov [this message]
2019-04-02 15:49 ` [PATCH v3 4/7] lib: update msgpuck library Kirill Shcherbatov
2019-04-03 17:49 ` [tarantool-patches] " Kirill Shcherbatov
2019-04-04 15:54 ` Vladimir Davydov
2019-04-05 17:17 ` [tarantool-patches] " Kirill Shcherbatov
2019-04-07 12:22 ` Vladimir Davydov
2019-04-02 15:49 ` [PATCH v3 5/7] box: introduce tuple_parse_iterator class Kirill Shcherbatov
2019-04-03 14:04 ` Vladimir Davydov
2019-04-05 17:17 ` [tarantool-patches] " Kirill Shcherbatov
2019-04-02 15:49 ` [PATCH v3 6/7] box: introduce field_map_builder class Kirill Shcherbatov
2019-04-03 14:38 ` Vladimir Davydov
2019-04-05 17:17 ` [tarantool-patches] " Kirill Shcherbatov
2019-04-03 16:30 ` Vladimir Davydov
2019-04-02 15:49 ` [PATCH v3 7/7] box: introduce multikey indexes in memtx Kirill Shcherbatov
2019-04-04 14:20 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=697b2d95-ed98-7b6e-09a9-621fcc2d6d9d@tarantool.org \
--to=kshcherbatov@tarantool.org \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [tarantool-patches] Re: [PATCH v3 3/7] box: move offset_slot init to tuple_format_add_field' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox