Re: [Tarantool-patches] [PATCH LUAROCKS v2 0/2] Move a rocks options filter from tarantoolctl to luarocks

[lvasiliev <lvasiliev@tarantool.org>]

On 19.03.2020 1:12, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patchset!
> 
> Generally the comments are the same as for the other rocks-related
> patchset:
> 
> - Add a @ChangeLog;
> - Provide a description of the patchset in the cover-letter. What
>    was made, how, why?
> 
> On 19/11/2019 09:52, Leonid wrote:
>> https://github.com/tarantool/tarantool/issues/4629
>> https://github.com/tarantool/luarocks/tree/lvasiliev/gh-4629-add-chdir-to-make
>>
>> Changes in v2:
>> - Move chdir before loading the rockspec file
>>
>> Leonid (2):
>>    Add the chdir option for make
>>    Add the tarantool options black list. Update help
>>
>>   src/luarocks/cmd/help.lua | 15 +++++++++------
>>   src/luarocks/cmd/make.lua | 22 ++++++++++++++++------
>>   src/luarocks/util.lua     | 25 ++++++++++++++++++++-----
>>   3 files changed, 45 insertions(+), 17 deletions(-)
>>
Hi. Thanks for the review!
New version of patchset with the corrections was sent.
Sorry, in first time I forgot to send a patch with tarantoolctl changes.

About testing:
You can read help (tarantoolctl rocks help) and try something from new 
commands(build config download init lint new_version purge which 
write_rockspec)
For example: tarantoolctl rocks download xavante
Or test some from breaking flags:
For example: tarantoolctl rocks search --all