From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Konstantin Osipov <kostja.osipov@gmail.com>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/2] fiber: destroy fiber.storage created by iproto
Date: Sat, 14 Dec 2019 17:49:54 +0100 [thread overview]
Message-ID: <67adef62-9767-06f0-32c5-53baa6ad491f@tarantool.org> (raw)
In-Reply-To: <20191214123333.GC17689@atlas>
Well, I still don't understand what you are keep saying and
what do you want, and since it does not look like I will, I
am out of this ticket.
On 14/12/2019 13:33, Konstantin Osipov wrote:
> * Konstantin Osipov <kostja.osipov@gmail.com> [19/12/14 15:30]:
>> I checked now, and Lua addeded debug.getupvalue() to Lua C API.
>>
>> On other words, fiber storage now can be implemented in pure Lua,
>> without any triggers.
>>
>> Back when we were writing, upvalue API was only available in C
>> API, and AFAIR there was no way to access upvalues from Lua, this
>> is why we had to come up with this hack.
>
> The feature can actually be deprecated. There is now a completely
> legitimate and easy to use way to have a request-local object with
> a user defined destructor in pure Lua.
>
> If you do want to keep it, you should try to minimized the damage
> to the core, not extend it.
>
next prev parent reply other threads:[~2019-12-14 16:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-08 19:28 [Tarantool-patches] [PATCH 0/2] Fiber storage leak Vladislav Shpilevoy
2019-12-08 19:28 ` [Tarantool-patches] [PATCH 1/2] fiber: unref fiber.storage via global Lua state Vladislav Shpilevoy
2019-12-11 23:57 ` Igor Munkin
2019-12-12 8:50 ` Konstantin Osipov
2019-12-12 23:38 ` Vladislav Shpilevoy
2019-12-13 10:44 ` Igor Munkin
2019-12-08 19:28 ` [Tarantool-patches] [PATCH 2/2] fiber: destroy fiber.storage created by iproto Vladislav Shpilevoy
2019-12-09 7:21 ` Konstantin Osipov
2019-12-09 23:31 ` Vladislav Shpilevoy
2019-12-10 8:21 ` Konstantin Osipov
2019-12-10 8:32 ` Konstantin Osipov
2019-12-10 22:59 ` Vladislav Shpilevoy
2019-12-11 7:08 ` Konstantin Osipov
2019-12-11 21:23 ` Vladislav Shpilevoy
2019-12-12 0:00 ` Igor Munkin
2019-12-12 23:37 ` Vladislav Shpilevoy
2019-12-13 13:35 ` Igor Munkin
2019-12-12 8:46 ` Konstantin Osipov
2019-12-13 0:02 ` Vladislav Shpilevoy
2019-12-13 7:58 ` Konstantin Osipov
2019-12-13 23:11 ` Vladislav Shpilevoy
2019-12-14 12:26 ` Konstantin Osipov
2019-12-14 12:30 ` Konstantin Osipov
2019-12-14 12:33 ` Konstantin Osipov
2019-12-14 16:49 ` Vladislav Shpilevoy [this message]
2019-12-14 20:59 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67adef62-9767-06f0-32c5-53baa6ad491f@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/2] fiber: destroy fiber.storage created by iproto' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox