From: Leonid Vasiliev <lvasiliev@tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>,
tarantool-patches@dev.tarantool.org
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
alexander.turenko@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3 0/4] Support Python 3 in tests and PEPify source code
Date: Wed, 23 Dec 2020 13:07:22 +0300 [thread overview]
Message-ID: <6778b956-f5d3-a2ab-8227-a71a6613817e@tarantool.org> (raw)
In-Reply-To: <6a4cfc82-ef53-f381-6772-6fdcb1a3bb35@tarantool.org>
Hi!
As far as I can see, the composition of the patchset has much changed
(also, it now has five patches instead of four). I suggest to send a new
clean version of the patchset.
On 13.12.2020 22:02, Sergey Bronnikov wrote:
> + tarantool-patches@dev.tarantool.org
>
> On 11.12.2020 11:42, sergeyb@tarantool.org wrote:
>> From: Sergey Bronnikov <sergeyb@tarantool.org>
>>
>> Changes v1:
>> - convert print statements to functions
>> - use "format()" instead of "%" everywhere
>>
>> Changes v2:
>> - make using quotes with strings consistent
>> - remove dead code
>> - remove empty prints
>> - added make target for running flake8
>> - added flake8 config
>> - added job to run flake8 on Gitlab CI
>>
>> Changes v3:
>> - removed three patches with flake8 integration
>> - fixed rest patches according to comments on review
>> - add a separate patch with converting dict.items() to a list
>> - add a new patch with conversion string to hex
>>
>> Gitlab CI: https://gitlab.com/tarantool/tarantool/-/jobs/904769000
>> Branch:
>> https://github.com/tarantool/tarantool/tree/ligurio/gh-5538-support-python3
>>
>> Issue: https://github.com/tarantool/tarantool/issues/5538
>>
>> Sergey Bronnikov (4):
>> test: convert print to function and make quotes use consistent
>> test: make dict.items() compatible with Python 3.x
>> test: make convert to hex compatible with Python 3.x
>> test: remove dead code in Python tests end extra newline
>>
>> test/app-tap/httpd.py | 42 ++---
>> test/box-py/args.test.py | 14 +-
>> test/box-py/bad_trigger.result | 2 -
>> test/box-py/bad_trigger.test.py | 20 +--
>> test/box-py/bootstrap.result | 2 +-
>> test/box-py/bootstrap.test.py | 16 +-
>> test/box-py/call.result | 12 +-
>> test/box-py/call.test.py | 92 +++++-----
>> test/box-py/iproto.result | 10 +-
>> test/box-py/iproto.test.py | 220 +++++++++++------------
>> test/box-py/print.result | 6 +-
>> test/box-py/print.test.py | 24 +--
>> test/box-py/snapshot.result | 4 +-
>> test/box-py/snapshot.test.py | 33 ++--
>> test/long_run-py/finalizers.result | 2 +-
>> test/long_run-py/finalizers.test.py | 8 +-
>> test/replication-py/cluster.result | 6 +-
>> test/replication-py/cluster.test.py | 217 +++++++++++-----------
>> test/replication-py/conflict.test.py | 54 +++---
>> test/replication-py/init_storage.test.py | 58 +++---
>> test/replication-py/multi.test.py | 78 ++++----
>> test/replication-py/swap.test.py | 55 +++---
>> test/xlog-py/big_lsn.test.py | 4 +-
>> test/xlog-py/dup_key.test.py | 22 +--
>> test/xlog-py/empty.test.py | 4 +-
>> test/xlog-py/lsn_gap.test.py | 11 +-
>> test/xlog-py/misc.test.py | 33 ++--
>> test/xlog-py/missing.test.py | 10 +-
>> 28 files changed, 530 insertions(+), 529 deletions(-)
>>
next prev parent reply other threads:[~2020-12-23 10:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1607675470.git.sergeyb@tarantool.org>
2020-12-11 8:42 ` [Tarantool-patches] [PATCH 1/4] test: convert print to function and make quotes use consistent sergeyb
2020-12-13 17:58 ` Vladislav Shpilevoy
2020-12-14 11:44 ` Sergey Bronnikov
2020-12-15 10:05 ` Leonid Vasiliev
2020-12-15 11:51 ` Sergey Bronnikov
2020-12-20 16:47 ` Vladislav Shpilevoy
2020-12-23 12:34 ` Sergey Bronnikov
2020-12-11 8:42 ` [Tarantool-patches] [PATCH 2/4] test: make dict.items() compatible with Python 3.x sergeyb
2020-12-13 17:58 ` Vladislav Shpilevoy
2020-12-15 12:40 ` Leonid Vasiliev
2020-12-11 8:42 ` [Tarantool-patches] [PATCH 3/4] test: make convert to hex " sergeyb
2020-12-15 11:55 ` Leonid Vasiliev
2020-12-16 14:04 ` Sergey Bronnikov
2020-12-17 18:26 ` Leonid Vasiliev
2020-12-22 8:15 ` [Tarantool-patches] [PATCH] test: make strings compatible with Python 3 sergeyb
2020-12-23 9:59 ` Leonid Vasiliev
2020-12-23 10:35 ` Sergey Bronnikov
2020-12-23 11:09 ` Leonid Vasiliev
2020-12-22 8:19 ` [Tarantool-patches] [PATCH 3/4] test: make convert to hex compatible with Python 3.x Sergey Bronnikov
2020-12-23 10:00 ` Leonid Vasiliev
2020-12-11 8:42 ` [Tarantool-patches] [PATCH 4/4] test: remove dead code in Python tests end extra newline sergeyb
2020-12-15 12:51 ` Leonid Vasiliev
2020-12-15 13:00 ` Sergey Bronnikov
2020-12-13 19:02 ` [Tarantool-patches] [PATCH v3 0/4] Support Python 3 in tests and PEPify source code Sergey Bronnikov
2020-12-23 10:07 ` Leonid Vasiliev [this message]
2020-12-23 12:42 ` Sergey Bronnikov
2020-12-23 23:51 ` Leonid Vasiliev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6778b956-f5d3-a2ab-8227-a71a6613817e@tarantool.org \
--to=lvasiliev@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3 0/4] Support Python 3 in tests and PEPify source code' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox