From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lvasiliev@tarantool.org>
Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 064C74765E0
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 23 Dec 2020 13:07:27 +0300 (MSK)
References: <cover.1607675470.git.sergeyb@tarantool.org>
 <6a4cfc82-ef53-f381-6772-6fdcb1a3bb35@tarantool.org>
From: Leonid Vasiliev <lvasiliev@tarantool.org>
Message-ID: <6778b956-f5d3-a2ab-8227-a71a6613817e@tarantool.org>
Date: Wed, 23 Dec 2020 13:07:22 +0300
MIME-Version: 1.0
In-Reply-To: <6a4cfc82-ef53-f381-6772-6fdcb1a3bb35@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [Tarantool-patches] [PATCH v3 0/4] Support Python 3 in tests
	and PEPify source code
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Bronnikov <sergeyb@tarantool.org>, tarantool-patches@dev.tarantool.org
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, alexander.turenko@tarantool.org

Hi!
As far as I can see, the composition of the patchset has much changed
(also, it now has five patches instead of four). I suggest to send a new
clean version of the patchset.

On 13.12.2020 22:02, Sergey Bronnikov wrote:
> + tarantool-patches@dev.tarantool.org
> 
> On 11.12.2020 11:42, sergeyb@tarantool.org wrote:
>> From: Sergey Bronnikov <sergeyb@tarantool.org>
>>
>> Changes v1:
>> - convert print statements to functions
>> - use "format()" instead of "%" everywhere
>>
>> Changes v2:
>> - make using quotes with strings consistent
>> - remove dead code
>> - remove empty prints
>> - added make target for running flake8
>> - added flake8 config
>> - added job to run flake8 on Gitlab CI
>>
>> Changes v3:
>> - removed three patches with flake8 integration
>> - fixed rest patches according to comments on review
>> - add a separate patch with converting dict.items() to a list
>> - add a new patch with conversion string to hex
>>
>> Gitlab CI: https://gitlab.com/tarantool/tarantool/-/jobs/904769000
>> Branch: 
>> https://github.com/tarantool/tarantool/tree/ligurio/gh-5538-support-python3 
>>
>> Issue: https://github.com/tarantool/tarantool/issues/5538
>>
>> Sergey Bronnikov (4):
>>    test: convert print to function and make quotes use consistent
>>    test: make dict.items() compatible with Python 3.x
>>    test: make convert to hex compatible with Python 3.x
>>    test: remove dead code in Python tests end extra newline
>>
>>   test/app-tap/httpd.py                    |  42 ++---
>>   test/box-py/args.test.py                 |  14 +-
>>   test/box-py/bad_trigger.result           |   2 -
>>   test/box-py/bad_trigger.test.py          |  20 +--
>>   test/box-py/bootstrap.result             |   2 +-
>>   test/box-py/bootstrap.test.py            |  16 +-
>>   test/box-py/call.result                  |  12 +-
>>   test/box-py/call.test.py                 |  92 +++++-----
>>   test/box-py/iproto.result                |  10 +-
>>   test/box-py/iproto.test.py               | 220 +++++++++++------------
>>   test/box-py/print.result                 |   6 +-
>>   test/box-py/print.test.py                |  24 +--
>>   test/box-py/snapshot.result              |   4 +-
>>   test/box-py/snapshot.test.py             |  33 ++--
>>   test/long_run-py/finalizers.result       |   2 +-
>>   test/long_run-py/finalizers.test.py      |   8 +-
>>   test/replication-py/cluster.result       |   6 +-
>>   test/replication-py/cluster.test.py      | 217 +++++++++++-----------
>>   test/replication-py/conflict.test.py     |  54 +++---
>>   test/replication-py/init_storage.test.py |  58 +++---
>>   test/replication-py/multi.test.py        |  78 ++++----
>>   test/replication-py/swap.test.py         |  55 +++---
>>   test/xlog-py/big_lsn.test.py             |   4 +-
>>   test/xlog-py/dup_key.test.py             |  22 +--
>>   test/xlog-py/empty.test.py               |   4 +-
>>   test/xlog-py/lsn_gap.test.py             |  11 +-
>>   test/xlog-py/misc.test.py                |  33 ++--
>>   test/xlog-py/missing.test.py             |  10 +-
>>   28 files changed, 530 insertions(+), 529 deletions(-)
>>