Re: [Tarantool-patches] [PATCH luajit 2/2] ci: introduce testing workflow with sanitizers

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Thanks for the patch! LGTM with minor comments below

Sergey

On 7/13/23 00:09, Igor Munkin wrote:
> This commit adds GitHub workflow running all available LuaJIT tests with
> LUAJIT_USE_ASAN option enabled. For now, sanitizers workflow works only
> for Linux/x86_64 as the most scaling setup in our CI. I believe we will
> be able to add other platforms being supported, when ARM64 and macOS

beware that ARM64 is absent in a list of supported platforms [1]

https://clang.llvm.org/docs/AddressSanitizer.html#supported-platforms

<snipped>

> +      - name: test
> +        env:
> +          # Enable as much checks as possible. See more info here:

However, some checks are *disabled*, for example "print_suppressions"

and "heap_profile" are disabled. Is it intentionally?

> +          # https://github.com/google/sanitizers/wiki/AddressSanitizerFlags
there are also LeakSanitizer flags here 
https://github.com/google/sanitizers/wiki/AddressSanitizerLeakSanitizer#flags
> +          ASAN_OPTIONS: "                    \
> +            detect_invalid_pointer_pairs=1:  \
> +            detect_leaks=1:                  \
> +            detect_stack_use_after_return=1: \
> +            dump_instruction_bytes=1:        \
> +            heap_profile=0:                  \
> +            print_suppressions=0             \
> +            symbolize=1:                     \
> +            unmap_shadow_on_exit=1:          \
> +          "
> +        run: cmake --build . --parallel --target LuaJIT-test
> +        working-directory: ${{ env.BUILDDIR }}