From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <max.kokryashkin@gmail.com>,
tarantool-patches@dev.tarantool.org, skaplun@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit v2 2/6] build: fix tool components handling
Date: Tue, 19 Dec 2023 16:56:56 +0300 [thread overview]
Message-ID: <6629e673-8259-4334-8e75-e49699e3b666@tarantool.org> (raw)
In-Reply-To: <3d34441cd94210ab916527ce95c8cba0ef1b8f4f.1701888856.git.m.kokryashkin@tarantool.org>
Thanks for the patch, LGTM
On 12/6/23 21:55, Maxim Kokryashkin wrote:
> Prior to this patch, memprof/process.lua wasn't added to the
> dependency list as a part of the memprof parser sources. Also,
> it wasn't installed into the system along with other memprof
> sources, which breaks the profile parser.
>
> Also, the sysprof parser sources weren't handled by the
> Makefile.original at all. The same applies to utils/avl.lua.
> This patch fixes that, so now it's possible to properly handle
> sysprof's parser.
>
> Part of tarantool/tarantool#5994
<snipped>
next prev parent reply other threads:[~2023-12-19 13:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 18:55 [Tarantool-patches] [PATCH luajit v2 0/6] profilers: refactor parsers Maxim Kokryashkin via Tarantool-patches
2023-12-06 18:55 ` [Tarantool-patches] [PATCH luajit v2 1/6] build: purge sysprof.collapse module Maxim Kokryashkin via Tarantool-patches
2023-12-12 10:18 ` Sergey Kaplun via Tarantool-patches
2023-12-19 12:20 ` Sergey Bronnikov via Tarantool-patches
2023-12-06 18:55 ` [Tarantool-patches] [PATCH luajit v2 2/6] build: fix tool components handling Maxim Kokryashkin via Tarantool-patches
2023-12-12 10:32 ` Sergey Kaplun via Tarantool-patches
2023-12-12 12:53 ` Maxim Kokryashkin via Tarantool-patches
2023-12-12 12:51 ` Sergey Kaplun via Tarantool-patches
2023-12-19 13:56 ` Sergey Bronnikov via Tarantool-patches [this message]
2023-12-06 18:55 ` [Tarantool-patches] [PATCH luajit v2 3/6] memprof: refactor `heap_chunk` data structure Maxim Kokryashkin via Tarantool-patches
2023-12-12 10:34 ` Sergey Kaplun via Tarantool-patches
2023-12-19 14:00 ` Sergey Bronnikov via Tarantool-patches
2023-12-06 18:55 ` [Tarantool-patches] [PATCH luajit v2 4/6] memprof: remove unused arguments Maxim Kokryashkin via Tarantool-patches
2023-12-12 10:44 ` Sergey Kaplun via Tarantool-patches
2023-12-19 14:01 ` Sergey Bronnikov via Tarantool-patches
2023-12-06 18:55 ` [Tarantool-patches] [PATCH luajit v2 5/6] memprof: introduce the `--human-readable` option Maxim Kokryashkin via Tarantool-patches
2023-12-12 10:54 ` Sergey Kaplun via Tarantool-patches
2023-12-20 12:24 ` Sergey Bronnikov via Tarantool-patches
2023-12-06 18:55 ` [Tarantool-patches] [PATCH luajit v2 6/6] profilers: print user-friendly errors Maxim Kokryashkin via Tarantool-patches
2023-12-12 11:51 ` Sergey Kaplun via Tarantool-patches
2023-12-12 12:54 ` Maxim Kokryashkin via Tarantool-patches
2023-12-12 12:54 ` Sergey Kaplun via Tarantool-patches
2023-12-29 12:27 ` Sergey Bronnikov via Tarantool-patches
2024-01-09 13:54 ` Maxim Kokryashkin via Tarantool-patches
2024-01-16 9:48 ` Sergey Bronnikov via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6629e673-8259-4334-8e75-e49699e3b666@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=max.kokryashkin@gmail.com \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit v2 2/6] build: fix tool components handling' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox