From: Oleg Babin <olegrok@tarantool.org>
To: Leonid Vasiliev <lvasiliev@tarantool.org>, v.shpilevoy@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] lua: introduce function to check that passed value is uuid
Date: Tue, 28 Jul 2020 11:34:48 +0300 [thread overview]
Message-ID: <64d25074-c400-b551-064f-01046d3d8edf@tarantool.org> (raw)
In-Reply-To: <ec8d3d05-b21b-39cb-1e02-f7dbbc49842a@tarantool.org>
Hi! Thanks for review.
On 28/07/2020 11:23, Leonid Vasiliev wrote:
> Hi! Thank you for the patch.
> LGTM.
>
> Up to you:
>
>> We've already have is_decimal function that checks allowed value
>
> If I'm not mistaken: "We already have".
Yes, thanks. Fixed and force-pushed.
And seems patch has two LGTMs and could be merged.
CCed Kirill.
next prev parent reply other threads:[~2020-07-28 8:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 18:20 olegrok
2020-07-27 20:19 ` Vladislav Shpilevoy
2020-07-28 8:23 ` Leonid Vasiliev
2020-07-28 8:34 ` Oleg Babin [this message]
2020-07-28 14:59 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64d25074-c400-b551-064f-01046d3d8edf@tarantool.org \
--to=olegrok@tarantool.org \
--cc=lvasiliev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] lua: introduce function to check that passed value is uuid' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox