Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org, "n.pettik" <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 2/4] sql: remove unused error codes, use enum instead of defines
Date: Wed, 4 Apr 2018 13:26:07 +0300	[thread overview]
Message-ID: <64bd8cfd-48ec-1171-d58e-94779d17b3f9@tarantool.org> (raw)
In-Reply-To: <3FC50B7F-FE28-4F8C-A79C-C287FD6EA1CB@tarantool.org>

> I do like move to enum, but what about removing this obsolete ’SQLITE’ prefix?
> Let it be just ’SQL_’. Moreover, some error seems to be SQLite specific.
> Great time to remove them, isn’t it?
> If you don’t want or don’t have time for this boring routine, you can create issue
> with ‘good first issue’ label.
I am afraid that a diff will be huge, if a rename SQLITE_OK, for 
example. Lets do it later, when more
source code and error codes will be removed.
https://github.com/tarantool/tarantool/issues/3315

Please, review the huge diff below very carefully. I could make a 
mistake here.

diff --git a/src/box/sql/vdbeInt.h b/src/box/sql/vdbeInt.h
index f8f4e566b..6ea8c91d7 100644
--- a/src/box/sql/vdbeInt.h
+++ b/src/box/sql/vdbeInt.h
@@ -442,7 +442,6 @@ struct Vdbe {
      int nScan;        /* Entries in aScan[] */
      ScanStatus *aScan;    /* Scan definitions for 
sqlite3_stmt_scanstatus() */
  #endif
-
  };

  /*

  reply	other threads:[~2018-04-04 10:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-03 15:34 [tarantool-patches] [PATCH 0/4] sql: refactor insertion and lua Vladislav Shpilevoy
2018-04-03 15:34 ` [tarantool-patches] [PATCH 1/4] sql: remove unused opcodes from OP_[Sorter/Idx][Insert/Replace] Vladislav Shpilevoy
2018-04-03 23:01   ` [tarantool-patches] " n.pettik
2018-04-04 10:26     ` Vladislav Shpilevoy
2018-04-04 11:51       ` n.pettik
2018-04-04 14:48         ` n.pettik
2018-04-03 15:34 ` [tarantool-patches] [PATCH 2/4] sql: remove unused error codes, use enum instead of defines Vladislav Shpilevoy
2018-04-03 23:01   ` [tarantool-patches] " n.pettik
2018-04-04 10:26     ` Vladislav Shpilevoy [this message]
2018-04-04 11:30       ` n.pettik
2018-04-03 15:34 ` [tarantool-patches] [PATCH 3/4] sql: simplify lua SQL executor Vladislav Shpilevoy
2018-04-03 23:02   ` [tarantool-patches] " n.pettik
2018-04-03 15:34 ` [tarantool-patches] [PATCH 4/4] sql: remove useless branching in insertOrReplace Vladislav Shpilevoy
2018-04-03 23:01   ` [tarantool-patches] " n.pettik
2018-04-05 11:43 ` [tarantool-patches] Re: [PATCH 0/4] sql: refactor insertion and lua Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64bd8cfd-48ec-1171-d58e-94779d17b3f9@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH 2/4] sql: remove unused error codes, use enum instead of defines' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox