Re: [Tarantool-patches] [tarantool-patches] [PATCH] replication: cancel replica joining thread at exit

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

Hi! Thanks for the patch!

> diff --git a/src/box/memtx_engine.h b/src/box/memtx_engine.h
> index c092f5d8e..43e16879d 100644
> --- a/src/box/memtx_engine.h
> +++ b/src/box/memtx_engine.h
> @@ -107,6 +107,8 @@ struct memtx_engine {
>  	uint64_t snap_io_rate_limit;
>  	/** Skip invalid snapshot records if this flag is set. */
>  	bool force_recovery;
> +	/** cord being currently used to join replica **/

Please, start the sentence from a capital letter,
and finish with a dot. Also, as you probably have seen
we use */ commend end mark, never **/.

I would also mention, that we need that pointer only
to be able to cancel the cord. Nothing else.

> +	struct cord *replica_join_cord;
>  	/** Common quota for tuples and indexes. */
>  	struct quota quota;
>  	/**
>