From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org, imeevma@tarantool.org
Cc: Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v3 1/1] sql: tarantoolctl "enter" with set language
Date: Thu, 2 Aug 2018 01:14:50 +0300 [thread overview]
Message-ID: <6484efa6-f68b-fc43-6d6c-0ff42e7a01a0@tarantool.org> (raw)
In-Reply-To: <a2ae7f96-024a-acec-9425-5df535aaad56@tarantool.org>
Kirill. How about to push it?
On 30/07/2018 13:39, Vladislav Shpilevoy wrote:
> Thanks for the patch!
>
> Please, write me in 'Copy' when sending a patch on review.
>
> The patch LGTM.
>
> On 30/07/2018 11:33, imeevma@tarantool.org wrote:
>> This patch allow to use option "--language" with
>> "tarantoolctl enter" command. Also default value
>> for language were added in default configuration
>> file. Language is either SQL or Lua.
>>
>> Closes #2385.
>>
>> @TarantoolBot document
>> Title: Language selection for tarantoolctl
>> "enter".
>> User can select either Lua or SQL when he uses tarantoolctl
>> "enter" command. It can be done using "--language=<language>"
>> syntax. Default language is set in tarantoolctl config file.
>> Usage:
>> tarantoolctl enter <app_name> --language=SQL
>> tarantoolctl enter <app_name> --language=Lua
>> ---
>> Branch: https://github.com/tarantool/tarantool/tree/imeevma/gh-2385-select-input-language-tarantoolctl
>> Issue: https://github.com/tarantool/tarantool/issues/2385
>>
>
next prev parent reply other threads:[~2018-08-01 22:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 8:33 [tarantool-patches] " imeevma
2018-07-30 10:39 ` [tarantool-patches] " Vladislav Shpilevoy
2018-08-01 22:14 ` Vladislav Shpilevoy [this message]
2018-08-02 8:35 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6484efa6-f68b-fc43-6d6c-0ff42e7a01a0@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v3 1/1] sql: tarantoolctl "enter" with set language' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox