Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org
Cc: kostja@tarantool.org
Subject: [tarantool-patches] [PATCH 2/5] swim: fix an obvious use-after-free
Date: Wed, 22 May 2019 22:52:18 +0300	[thread overview]
Message-ID: <647cd1a5914c82d328f1bfc13510e1964d734872.1558554655.git.v.shpilevoy@tarantool.org> (raw)
In-Reply-To: <cover.1558554655.git.v.shpilevoy@tarantool.org>

Follow up #3234
---
 src/lib/swim/swim.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/swim/swim.c b/src/lib/swim/swim.c
index 67700027e..eb7aa6f01 100644
--- a/src/lib/swim/swim.c
+++ b/src/lib/swim/swim.c
@@ -2014,8 +2014,8 @@ swim_quit(struct swim *swim)
 		 swim_encode_quit(swim, &task->packet);
 	assert(rc == 2);
 	mp_encode_map(header, rc);
-	swim_quit_step_complete(task, &swim->scheduler, 0);
 	swim->self->status = MEMBER_LEFT;
+	swim_quit_step_complete(task, &swim->scheduler, 0);
 }
 
 struct swim_member *
-- 
2.20.1 (Apple Git-117)

  parent reply	other threads:[~2019-05-22 19:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-22 19:52 [tarantool-patches] [PATCH 0/5] SWIM bug fixes Vladislav Shpilevoy
2019-05-22 19:52 ` [tarantool-patches] [PATCH 1/5] swim: fix an obvious leak in swim_delete() Vladislav Shpilevoy
2019-05-22 19:52 ` Vladislav Shpilevoy [this message]
2019-05-22 19:52 ` [tarantool-patches] [PATCH 3/5] swim: fix flaky parts in swim/swim.test.lua Vladislav Shpilevoy
2019-05-22 19:52 ` [tarantool-patches] [PATCH 4/5] swim: be ready to idle round steps when net is slow Vladislav Shpilevoy
2019-05-22 19:52 ` [tarantool-patches] [PATCH 5/5] swim: allow to set codec before cfg Vladislav Shpilevoy
2019-05-22 21:14 ` [tarantool-patches] Re: [PATCH 0/5] SWIM bug fixes Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=647cd1a5914c82d328f1bfc13510e1964d734872.1558554655.git.v.shpilevoy@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [tarantool-patches] [PATCH 2/5] swim: fix an obvious use-after-free' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox