From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Roman Khabibov <roman.habibov@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 1/2] coio/say: fix getaddrinfo error handling on macOS
Date: Sun, 26 Apr 2020 19:20:59 +0200 [thread overview]
Message-ID: <647801fa-6078-0258-7593-653b317b66ec@tarantool.org> (raw)
In-Reply-To: <20200312102434.97300-2-roman.habibov@tarantool.org>
Hi! I didn't review the patch. Just noticed, that you need the
stacked diag in one place, and I have a comment on that.
> diff --git a/src/lib/core/say.c b/src/lib/core/say.c
> index 64a637c58..8ad88ad57 100644
> --- a/src/lib/core/say.c
> +++ b/src/lib/core/say.c
> @@ -593,6 +596,11 @@ log_syslog_init(struct log *log, const char *init_str)
> say_free_syslog_opts(&opts);
> log->fd = log_syslog_connect(log);
> if (log->fd < 0) {
> + /*
> + * We need to log a diagnostics here until stacked
> + * diagnostics will be implemented (#1148).
> + */
> + diag_log();
Stacked diagnostics is implemented now.
next prev parent reply other threads:[~2020-04-26 17:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 10:24 [Tarantool-patches] [PATCH v2 0/2] Return getaddrinfo() errors Roman Khabibov
2020-03-12 10:24 ` [Tarantool-patches] [PATCH v2 1/2] coio/say: fix getaddrinfo error handling on macOS Roman Khabibov
2020-03-29 8:51 ` Sergey Ostanevich
2020-03-29 9:12 ` Alexander Turenko
2020-04-06 2:07 ` Roman Khabibov
2020-04-17 9:37 ` Sergey Ostanevich
2020-04-24 11:32 ` Roman Khabibov
2020-06-23 13:27 ` Roman Khabibov
2020-07-23 14:12 ` Sergey Ostanevich
2020-07-28 9:26 ` Roman Khabibov
2020-04-26 17:20 ` Vladislav Shpilevoy [this message]
2020-03-12 10:24 ` [Tarantool-patches] [PATCH v2 2/2] lua: return getaddrinfo() errors Roman Khabibov
2020-03-29 9:07 ` Sergey Ostanevich
2020-03-29 9:25 ` Alexander Turenko
2020-04-06 2:08 ` Roman Khabibov
2020-04-16 10:27 ` Sergey Ostanevich
2020-04-24 11:42 ` Roman Khabibov
2020-04-24 17:18 ` Sergey Ostanevich
2020-04-26 3:16 ` Roman Khabibov
2020-04-26 15:46 ` Alexander Turenko
2020-04-26 16:26 ` Roman Khabibov
2020-07-13 9:51 ` sergos
2020-07-28 14:08 ` [Tarantool-patches] [PATCH v2 0/2] Return " Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=647801fa-6078-0258-7593-653b317b66ec@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=roman.habibov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 1/2] coio/say: fix getaddrinfo error handling on macOS' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox