From: Kirill Shcherbatov <kshcherbatov@tarantool.org> To: tarantool-patches@freelists.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Subject: [tarantool-patches] Re: [PATCH v1 6/6] sql: make sql checks on server side Date: Thu, 29 Nov 2018 17:09:26 +0300 [thread overview] Message-ID: <64471afd-a041-d302-28ff-cfa36404e12c@tarantool.org> (raw) In-Reply-To: <d363c1ceb0f93b9c3457c373042edad6a5138443.1543496928.git.kshcherbatov@tarantool.org> Sorry, there are a few minor fixes that I pushed on branch. > + if (new_tuple != NULL && space->sql_checks != NULL) { > + const char *old_tuple_raw = old_tuple != NULL ? > + tuple_data(old_tuple) : NULL; > + const char *new_tuple_raw = new_tuple != NULL ? > + tuple_data(new_tuple) : NULL; I've dropped this redundant new_tuple != NULL on branch > +/* > + * Terminate the current execution of an SQL statement and reset > + * it back to its starting state so that it can be reused. A > + * success code from the prior execution is returned. > + * > + * This routine sets the error code and string returned by > + * sqlite3_errcode(), sqlite3_errmsg() and sqlite3_errmsg16(). > + */ > +int > +sqlite3_reset(sqlite3_stmt * pStmt); I've written doxigen comment on branch and have refactored body to follow our codestyle. > +static inline char * > +sql_stmt_err(struct sqlite3_stmt *stmt) > +{ > + struct Vdbe *v = (struct Vdbe *)stmt; > + return v->zErrMsg; > +} I've dropped this useless routine on branch.
next prev parent reply other threads:[~2018-11-29 14:09 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-29 13:09 [tarantool-patches] [PATCH v1 0/6] sql: Checks " Kirill Shcherbatov 2018-11-29 13:09 ` [tarantool-patches] [PATCH v1 1/6] box: rename space->opts checks to checks_ast Kirill Shcherbatov 2018-11-29 13:09 ` [tarantool-patches] [PATCH v1 2/6] sql: disallow use of TYPEOF in Check Kirill Shcherbatov 2018-11-29 13:09 ` [tarantool-patches] [PATCH v1 3/6] box: exported sql_bind structure and API Kirill Shcherbatov 2018-11-29 13:09 ` [tarantool-patches] [PATCH v1 4/6] sql: release OP_Idx{Insert,Replace} p2 argument Kirill Shcherbatov 2018-11-29 13:09 ` [tarantool-patches] [PATCH v1 5/6] sql: fix incomplete UPDATE on IdxInsert failured Kirill Shcherbatov 2018-11-29 13:09 ` [tarantool-patches] [PATCH v1 6/6] sql: make sql checks on server side Kirill Shcherbatov 2018-11-29 14:09 ` Kirill Shcherbatov [this message] 2018-11-29 18:41 ` [tarantool-patches] " Kirill Shcherbatov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=64471afd-a041-d302-28ff-cfa36404e12c@tarantool.org \ --to=kshcherbatov@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=v.shpilevoy@tarantool.org \ --subject='[tarantool-patches] Re: [PATCH v1 6/6] sql: make sql checks on server side' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox