Re: [Tarantool-patches] [PATCH v1 0/2] Add DOUBLE type to SQL

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

Thanks for the patch! LGTM.

Nikita, please, do a second review.

On 21/12/2019 17:03, imeevma@tarantool.org wrote:
> This patch-set adds the DOUBLE type to SQL. In the first patch of
> the set, the field type DOUBLE is added to Tarantool. In the
> second patch, the DOUBLE type is added to SQL.
> 
> https://github.com/tarantool/tarantool/issues/3812
> https://github.com/tarantool/tarantool/tree/imeevma/gh-3812-add-double-type
> 
> Mergen Imeev (2):
>   box: introduce DOUBLE field type
>   sql: introduce DOUBLE type
> 
>  extra/mkkeywordhash.c                      |   2 +-
>  src/box/field_def.c                        |  28 ++-
>  src/box/field_def.h                        |   1 +
>  src/box/sql/expr.c                         |   6 +-
>  src/box/sql/parse.y                        |   3 +-
>  src/box/sql/sqlInt.h                       |   3 +-
>  src/box/sql/vdbe.c                         |   4 +
>  src/box/sql/vdbemem.c                      |  15 +-
>  src/box/tuple_compare.cc                   |  24 ++
>  test/engine/insert.result                  | 151 +++++++++++
>  test/engine/insert.test.lua                |  51 ++++
>  test/sql/gh-3888-values-blob-assert.result |   4 +-
>  test/sql/misc.result                       |   4 +-
>  test/sql/types.result                      | 390 ++++++++++++++++++++++++++++-
>  test/sql/types.test.lua                    |  66 +++++
>  15 files changed, 716 insertions(+), 36 deletions(-)
>