From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: [Tarantool-patches] [PATCH v8 09/14] test: fix luacheck warnings W511 in test/sql-tap
Date: Thu, 21 Jan 2021 15:50:09 +0300 [thread overview]
Message-ID: <6304e1eeb205e3fce71d6f739afadbe5b5582933.1611232655.git.sergeyb@tarantool.org> (raw)
In-Reply-To: <cover.1611232655.git.sergeyb@tarantool.org>
From: Sergey Bronnikov <sergeyb@tarantool.org>
W511 (Unreachable code)
Part of #5464
---
.luacheckrc | 2 --
test/sql-tap/date.test.lua | 3 ++-
test/sql-tap/select1.test.lua | 3 ++-
test/sql-tap/table.test.lua | 3 ++-
test/sql-tap/tkt-bd484a090c.test.lua | 3 ++-
test/sql-tap/tkt2192.test.lua | 3 ++-
6 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/.luacheckrc b/.luacheckrc
index 31f9528ad..88fc34fa4 100644
--- a/.luacheckrc
+++ b/.luacheckrc
@@ -51,8 +51,6 @@ exclude_files = {
files["test/sql-tap/**/*.lua"] = {
ignore = {
- -- Unreachable code.
- "511",
-- Loop can be executed at most once.
"512",
-- An empty if branch.
diff --git a/test/sql-tap/date.test.lua b/test/sql-tap/date.test.lua
index fe5150719..0b37d52f8 100755
--- a/test/sql-tap/date.test.lua
+++ b/test/sql-tap/date.test.lua
@@ -29,7 +29,8 @@ test:plan(0)
-- Disabled until #3694 is resolved.
--
-if false then
+local is_gh_3694_closed = false
+if is_gh_3694_closed then
local function datetest(tnum, expr, result)
test:do_test(
"date-"..tnum,
diff --git a/test/sql-tap/select1.test.lua b/test/sql-tap/select1.test.lua
index d1301e5ad..2f61ae0ec 100755
--- a/test/sql-tap/select1.test.lua
+++ b/test/sql-tap/select1.test.lua
@@ -1513,7 +1513,8 @@ test:do_execsql_test(
-- TODO: This test is failing because f1 is now being loaded off the
-- disk as a vdbe integer, not a string. Hence the value of f1/(f1-11)
-- changes because of rounding. Disable the test for now.
-if false
+local is_gh_5737_closed = false
+if is_gh_5737_closed
then
test:do_execsql_test(
"select1-8.4",
diff --git a/test/sql-tap/table.test.lua b/test/sql-tap/table.test.lua
index 2817e1e72..bb36d994e 100755
--- a/test/sql-tap/table.test.lua
+++ b/test/sql-tap/table.test.lua
@@ -945,7 +945,8 @@ test:do_execsql_test(
--
-- Disabled until #3694 is resolved.
--
-if false then
+local is_gh_3694_closed = false
+if is_gh_3694_closed then
test:do_execsql_test(
"table-13.1",
[[
diff --git a/test/sql-tap/tkt-bd484a090c.test.lua b/test/sql-tap/tkt-bd484a090c.test.lua
index 6187fee7f..6cd219722 100755
--- a/test/sql-tap/tkt-bd484a090c.test.lua
+++ b/test/sql-tap/tkt-bd484a090c.test.lua
@@ -21,7 +21,8 @@ test:plan(0)
-- Disabled until #3694 is resolved.
--
-if false then
+local is_gh_3694_closed = false
+if is_gh_3694_closed then
test:do_test(
1.1,
function()
diff --git a/test/sql-tap/tkt2192.test.lua b/test/sql-tap/tkt2192.test.lua
index dabdfd141..74ec19a63 100755
--- a/test/sql-tap/tkt2192.test.lua
+++ b/test/sql-tap/tkt2192.test.lua
@@ -26,7 +26,8 @@ test:plan(4)
-- Disabled until #3694 is resolved.
--
-if false then
+local is_gh_3694_closed = false
+if is_gh_3694_closed then
test:do_execsql_test(
"tkt2192-1.1",
[[
--
2.25.1
next prev parent reply other threads:[~2021-01-21 12:54 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 12:49 [Tarantool-patches] [PATCH v8 00/14] Fix luacheck warnings in test/sql and test/sql-tap Sergey Bronnikov via Tarantool-patches
2021-01-21 12:49 ` [Tarantool-patches] [PATCH v8 01/14] test: fix luacheck warnings in test/sql Sergey Bronnikov via Tarantool-patches
2021-01-21 12:49 ` [Tarantool-patches] [PATCH v8 02/14] test: remove functions to open and close SQL connection Sergey Bronnikov via Tarantool-patches
2021-01-21 12:49 ` [Tarantool-patches] [PATCH v8 03/14] test: fix luacheck warnings W113 in test/sql-tap Sergey Bronnikov via Tarantool-patches
2021-01-24 17:33 ` Vladislav Shpilevoy via Tarantool-patches
2021-02-06 17:52 ` Vladislav Shpilevoy via Tarantool-patches
2021-02-16 12:02 ` Sergey Bronnikov via Tarantool-patches
2021-02-23 21:25 ` Vladislav Shpilevoy via Tarantool-patches
2021-02-25 10:39 ` Sergey Bronnikov via Tarantool-patches
2021-02-26 23:42 ` Vladislav Shpilevoy via Tarantool-patches
2021-02-27 17:53 ` Sergey Bronnikov via Tarantool-patches
2021-02-28 15:30 ` Vladislav Shpilevoy via Tarantool-patches
2021-03-01 13:26 ` Sergey Bronnikov via Tarantool-patches
2021-01-21 12:49 ` [Tarantool-patches] [PATCH v8 04/14] test: fix luacheck warnings W211 " Sergey Bronnikov via Tarantool-patches
2021-01-24 17:34 ` Vladislav Shpilevoy via Tarantool-patches
2021-02-16 14:09 ` Sergey Bronnikov via Tarantool-patches
2021-02-23 21:26 ` Vladislav Shpilevoy via Tarantool-patches
2021-02-25 11:02 ` Sergey Bronnikov via Tarantool-patches
2021-02-26 23:42 ` Vladislav Shpilevoy via Tarantool-patches
2021-02-27 17:09 ` Sergey Bronnikov via Tarantool-patches
2021-02-28 15:30 ` Vladislav Shpilevoy via Tarantool-patches
2021-03-01 13:46 ` Sergey Bronnikov via Tarantool-patches
2021-03-01 21:27 ` Vladislav Shpilevoy via Tarantool-patches
2021-03-02 8:05 ` Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 05/14] test: fix luacheck warnings W212 " Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 06/14] test: fix laucheck warnings W213 " Sergey Bronnikov via Tarantool-patches
2021-01-24 17:35 ` Vladislav Shpilevoy via Tarantool-patches
2021-01-29 16:32 ` Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 07/14] test: fix luacheck warnings W231 " Sergey Bronnikov via Tarantool-patches
2021-01-24 17:35 ` Vladislav Shpilevoy via Tarantool-patches
2021-01-29 22:39 ` Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 08/14] test: fix luacheck warnings W311 " Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` Sergey Bronnikov via Tarantool-patches [this message]
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 10/14] test: fix luacheck warnings W512 " Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 11/14] test: fix luacheck warnings W542 " Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 12/14] test: fix luacheck warnings W612, W613, W614 " Sergey Bronnikov via Tarantool-patches
2021-01-24 17:36 ` Vladislav Shpilevoy via Tarantool-patches
2021-01-29 16:23 ` Sergey Bronnikov via Tarantool-patches
2021-01-29 21:50 ` Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 13/14] test: fix luacheck warnings W621 " Sergey Bronnikov via Tarantool-patches
2021-01-24 17:37 ` Vladislav Shpilevoy via Tarantool-patches
2021-01-29 16:11 ` Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 14/14] luacheck: add issues for suppressed warnings Sergey Bronnikov via Tarantool-patches
2021-01-24 17:37 ` Vladislav Shpilevoy via Tarantool-patches
2021-01-29 16:13 ` Sergey Bronnikov via Tarantool-patches
2021-03-01 21:37 ` [Tarantool-patches] [PATCH v8 00/14] Fix luacheck warnings in test/sql and test/sql-tap Vladislav Shpilevoy via Tarantool-patches
2021-03-02 9:47 ` Kirill Yukhin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6304e1eeb205e3fce71d6f739afadbe5b5582933.1611232655.git.sergeyb@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v8 09/14] test: fix luacheck warnings W511 in test/sql-tap' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox