[tarantool-patches] Re: [PATCH 1/2] sql: allow key_def to be NULL for ephemeral create

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

Hello. Thanks for fixes!

> diff --git a/src/box/sql/delete.c b/src/box/sql/delete.c
> index 3455f52..2c1ce44 100644
> --- a/src/box/sql/delete.c
> +++ b/src/box/sql/delete.c
> @@ -386,14 +386,9 @@ sqlite3DeleteFrom(Parse * pParse,	/* The parser context */
>   			iPk = pParse->nMem + 1;
>   			pParse->nMem += nPk;
>   			iEphCur = pParse->nTab++;
> -			struct key_def *def = key_def_new(nPk);
> -			if (def == NULL) {
> -				sqlite3OomFault(db);
> -				goto delete_from_cleanup;
> -			}
>   			addrEphOpen =
>   				sqlite3VdbeAddOp4(v, OP_OpenTEphemeral, iEphCur,
> -						  nPk, 0, (char*)def, P4_KEYDEF);
> +						  nPk);

Compilation error.

/Users/v.shpilevoy/Work/Repositories/tarantool/src/box/sql/delete.c:391:12: error: too few arguments to function call, expected 7, have 4
                                                   nPk);
                                                      ^
/Users/v.shpilevoy/Work/Repositories/tarantool/src/box/sql/vdbe.h:227:1: note: 'sqlite3VdbeAddOp4' declared here
int sqlite3VdbeAddOp4(Vdbe *, int, int, int, int, const char *zP4, int);
^
1 error generated.