From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] fio/coio: handle partial writes
Date: Thu, 11 Jun 2020 21:56:31 +0200 [thread overview]
Message-ID: <616766fd-204e-805e-bb19-2ed2e06e73ec@tarantool.org> (raw)
In-Reply-To: <20200611194316.GP134822@grain>
On 11/06/2020 21:43, Cyrill Gorcunov wrote:
> On Thu, Jun 11, 2020 at 09:36:08PM +0200, Vladislav Shpilevoy wrote:
>> Thanks for the fixes! Seems like you didn't push them.
>
> Hmm... I pushed into gorcunov/gh-4651-partial-write-2 branch.
> https://lists.tarantool.org/pipermail/tarantool-patches/2020-June/017606.html
>
> If you mean to merge into master branch -- I don't have such rights ;)
Aha, so you changed the branch, but didn't say it anywhere. I was
looking at the branch you specified in the cover letter. Just a note -
better do a force push on the same branch. Having all these v1, v2, v15,
does not simplify the review. Even when you mention branch change in
one of the emails, still during the active review process with lots of
emails this one could be lost, and people would review the old branch
accidentally.
next prev parent reply other threads:[~2020-06-11 19:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 21:39 Cyrill Gorcunov
2020-05-06 17:08 ` Alexander Turenko
2020-05-15 9:00 ` Cyrill Gorcunov
2020-06-09 16:55 ` Alexander Turenko
2020-06-09 22:55 ` Vladislav Shpilevoy
2020-06-09 22:55 ` Vladislav Shpilevoy
2020-06-10 7:52 ` Cyrill Gorcunov
2020-06-11 19:36 ` Vladislav Shpilevoy
2020-06-11 19:43 ` Cyrill Gorcunov
2020-06-11 19:56 ` Vladislav Shpilevoy [this message]
2020-06-11 20:12 ` Cyrill Gorcunov
2020-06-11 19:56 ` Vladislav Shpilevoy
-- strict thread matches above, loose matches on Subject: below --
2019-11-26 18:05 [Tarantool-patches] [PATCH] fio/coio: Handle " Cyrill Gorcunov
2019-12-04 9:44 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=616766fd-204e-805e-bb19-2ed2e06e73ec@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] fio/coio: handle partial writes' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox