From: "n.pettik" <korablev@tarantool.org> To: tarantool-patches@freelists.org Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Subject: [tarantool-patches] Re: [PATCH 2/2] schema: add exact field count to SQL stat spaces Date: Thu, 21 Mar 2019 18:22:49 +0300 [thread overview] Message-ID: <60BB00E1-8D5E-4AFD-A86E-30CE45D00446@tarantool.org> (raw) In-Reply-To: <b5c4a403-d9d4-b986-557e-80e4ec854d6f@tarantool.org> > On 21 Mar 2019, at 16:31, Vladislav Shpilevoy <v.shpilevoy@tarantool.org> wrote: > > On that branch tests sql-tap/gh2548-select-compound-limit.test.lua > and sql-tap/gh2250-trigger-chain-limit.test.lua fail. Are you sure? Travis is green; on my local machine both release and debug builds pass these tests as well (memtx and vinyl cases). Could you check it again, or provide more details concerning fails? > On 19/03/2019 02:51, Nikita Pettik wrote: >> As a rule, system spaces don't feature exact field count. There is a >> reason for that: almost all of them have on replace triggers, which >> extract data from tuple and verify it. However, _sql_stat1 and >> _sql_stat4 spaces containing SQL specific statistics don't have such >> triggers. Hence, one can insert tuple to this space with greater number >> of fields, than format says. To prevent this, let's explicitly set exact >> field count to number of fields in format. >> --- >> src/box/bootstrap.snap | Bin 1831 -> 1840 bytes >> src/box/lua/upgrade.lua | 29 ++++++++++++++++++++++++++++- >> test/box-py/bootstrap.result | 6 +++--- >> test/box/access_misc.result | 4 ++-- >> test/sql/upgrade.result | 39 +++++++++++++++++++++++++++++++++++++-- >> test/sql/upgrade.test.lua | 13 +++++++++++++ >> 6 files changed, 83 insertions(+), 8 deletions(-)
next prev parent reply other threads:[~2019-03-21 15:22 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-18 23:51 [tarantool-patches] [PATCH 0/2] Fix wrong field count in bytecode for ANALYZE Nikita Pettik 2019-03-18 23:51 ` [tarantool-patches] [PATCH 1/2] sql: fix OP_MakeRecord argument of ANALYZE bytecode Nikita Pettik 2019-03-18 23:51 ` [tarantool-patches] [PATCH 2/2] schema: add exact field count to SQL stat spaces Nikita Pettik 2019-03-21 13:31 ` [tarantool-patches] " Vladislav Shpilevoy 2019-03-21 15:22 ` n.pettik [this message] 2019-03-21 15:39 ` Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=60BB00E1-8D5E-4AFD-A86E-30CE45D00446@tarantool.org \ --to=korablev@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=v.shpilevoy@tarantool.org \ --subject='[tarantool-patches] Re: [PATCH 2/2] schema: add exact field count to SQL stat spaces' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox