From: sergos via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Maksim Kokryashkin <max.kokryashkin@gmail.com> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit v3 2/4] Disable unreliable assertion for external frame unwinding. Date: Wed, 3 May 2023 12:31:07 +0300 [thread overview] Message-ID: <609F7531-BD34-4D98-BC9F-6F2414DDECCB@tarantool.org> (raw) In-Reply-To: <20230328000317.33238-3-max.kokryashkin@gmail.com> Thanks for the patch! LGTM Sergos. > On 28 Mar 2023, at 03:03, Maksim Kokryashkin <max.kokryashkin@gmail.com> wrote: > > From: Mike Pall <mike> > > Broken on Fedora/ARM64. Reported by Yichun Zhang. > > (cherry-picked from commit e957737650e060d5bf1c2909b741cc3dffe073ac) > > This patch disables the assertion that failed because of > incorrectly constructed unwind information. That debug > info generation was fixed in the scope of > tarantool/tarantool#6096 with commit > b731df1c0392cf7008be2e3c4112e1edb2392de4 ("ARM64: Reorder > interpreter stack frame and fix unwinding.") > This patch is backported only for consistency. ^ the history? > > Maxim Kokryashkin: > * added the description for the problem > > Part of tarantool/tarantool#7745 > Part of tarantool/tarantool#8069 > Relates to tarantool/tarantool#6096 > --- > src/lj_err.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/lj_err.c b/src/lj_err.c > index c7fd9e65..f6200233 100644 > --- a/src/lj_err.c > +++ b/src/lj_err.c > @@ -488,7 +488,9 @@ void lj_err_verify(void) > ** lj_assertX(_Unwind_Find_FDE((void *)_Unwind_RaiseException, &ehb), "broken build: external frame unwinding enabled, but system libraries have no unwind tables"); > */ > lua_assert(_Unwind_Find_FDE((void *)lj_err_throw, &ehb)); > + /* Check disabled, because of broken Fedora/ARM64. See #722. > lua_assert(_Unwind_Find_FDE((void *)_Unwind_RaiseException, &ehb)); > + */ > } > #endif > > -- > 2.37.1 (Apple Git-137.1) >
next prev parent reply other threads:[~2023-05-03 9:31 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-28 0:03 [Tarantool-patches] [PATCH luajit v3 0/4] jit: add exception unwinding Maksim Kokryashkin via Tarantool-patches 2023-03-28 0:03 ` [Tarantool-patches] [PATCH luajit v3 1/4] Handle on-trace OOM errors from helper functions Maksim Kokryashkin via Tarantool-patches 2023-04-05 6:32 ` Sergey Kaplun via Tarantool-patches 2023-03-28 0:03 ` [Tarantool-patches] [PATCH luajit v3 2/4] Disable unreliable assertion for external frame unwinding Maksim Kokryashkin via Tarantool-patches 2023-05-03 9:31 ` sergos via Tarantool-patches [this message] 2023-03-28 0:03 ` [Tarantool-patches] [PATCH luajit v3 3/4] OSX: " Maksim Kokryashkin via Tarantool-patches 2023-03-28 0:03 ` [Tarantool-patches] [PATCH luajit v3 4/4] Fix IR_RENAME snapshot number. Follow-up fix for a32aeadc Maksim Kokryashkin via Tarantool-patches 2023-04-05 5:33 ` Sergey Kaplun via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=609F7531-BD34-4D98-BC9F-6F2414DDECCB@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=max.kokryashkin@gmail.com \ --cc=sergos@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit v3 2/4] Disable unreliable assertion for external frame unwinding.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox