From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0248E4195A5; Wed, 3 May 2023 12:31:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0248E4195A5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1683106280; bh=eISk3zQExxSaThatMMcWtMPBpJP4bwTCjfj4qFo64Lg=; h=In-Reply-To:Date:References:To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=duPfnklOI7i3kdMQ/r0O0KugrEYZVw6How0eJU9pdwe+oW+1GlHXJ68bDGK/GiFDK 8DAmVaXxVYsaY2C6I4vz+phm0UaKBPh7M2a0XqOoVAqzk31of5DsGWRsUIPzUy2com VOCq1Bb5OskQSy46DVLqo7dWToDVFem2TABgCy/k= Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [95.163.41.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9A65F4195A5 for ; Wed, 3 May 2023 12:31:18 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9A65F4195A5 Received: by smtp48.i.mail.ru with esmtpa (envelope-from ) id 1pu8pR-00BQPE-RQ; Wed, 03 May 2023 12:31:18 +0300 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\)) In-Reply-To: <20230328000317.33238-3-max.kokryashkin@gmail.com> Date: Wed, 3 May 2023 12:31:07 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <609F7531-BD34-4D98-BC9F-6F2414DDECCB@tarantool.org> References: <20230328000317.33238-1-max.kokryashkin@gmail.com> <20230328000317.33238-3-max.kokryashkin@gmail.com> To: Maksim Kokryashkin X-Mailer: Apple Mail (2.3731.500.231) X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD968FA37C2F3F940C0DCACD1F47C207285FC7475CBF11DB3B2182A05F5380850404C228DA9ACA6FE27BDF6CA208205DE066C1F7208E22043E5B3C3659313D57A4D7DA14FBA07BD844D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE716FAD50E497B9C14EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375448D590B04CE87D8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8ED783275B316A346D637DA7F79B24D6E117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCC899C4B0487787E7A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520C65AC60A1F0286FEBDFBBEFFF4125B51D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE4B6963042765DA4BE21AE983DBD7FFC1D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE32A336C6518635091C0837EA9F3D19764C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006377AA2284B41911753EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5EE497C868652AADEDB8517EBCFDD4B7586422C79E4994780F87CCE6106E1FC07E67D4AC08A07B9B062B3BD3CC35DA588CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF86CE5D13D20575EA2CF4A5A70EEEFC86726610CAC75A91B7799DF6ED5A91D0C68B42E79199D3D3ED14EE98CD8E9D35FC422D9B375D61D132A7D0000BBE5D5A6BF4E8A8FB6BF8EBF5 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojtUGOBMG7VVP4FWgL1EZXXQ== X-Mailru-Sender: 5AA3D5B9D8C486466A1CB9683971E69C9037AE49370260357C0DB782CA66E028D775E2315FC03E4019381EE24192DF5555834048F03EF5D4C9A814A92B2E3B1BA4250FC3964EA4964198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v3 2/4] Disable unreliable assertion for external frame unwinding. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: sergos via Tarantool-patches Reply-To: sergos Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! LGTM Sergos. > On 28 Mar 2023, at 03:03, Maksim Kokryashkin = wrote: >=20 > From: Mike Pall >=20 > Broken on Fedora/ARM64. Reported by Yichun Zhang. >=20 > (cherry-picked from commit e957737650e060d5bf1c2909b741cc3dffe073ac) >=20 > This patch disables the assertion that failed because of > incorrectly constructed unwind information. That debug > info generation was fixed in the scope of > tarantool/tarantool#6096 with commit > b731df1c0392cf7008be2e3c4112e1edb2392de4 ("ARM64: Reorder > interpreter stack frame and fix unwinding.") > This patch is backported only for consistency. ^ the history? >=20 > Maxim Kokryashkin: > * added the description for the problem >=20 > Part of tarantool/tarantool#7745 > Part of tarantool/tarantool#8069 > Relates to tarantool/tarantool#6096 > --- > src/lj_err.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/src/lj_err.c b/src/lj_err.c > index c7fd9e65..f6200233 100644 > --- a/src/lj_err.c > +++ b/src/lj_err.c > @@ -488,7 +488,9 @@ void lj_err_verify(void) > ** lj_assertX(_Unwind_Find_FDE((void *)_Unwind_RaiseException, = &ehb), "broken build: external frame unwinding enabled, but system = libraries have no unwind tables"); > */ > lua_assert(_Unwind_Find_FDE((void *)lj_err_throw, &ehb)); > + /* Check disabled, because of broken Fedora/ARM64. See #722. > lua_assert(_Unwind_Find_FDE((void *)_Unwind_RaiseException, &ehb)); > + */ > } > #endif >=20 > --=20 > 2.37.1 (Apple Git-137.1) >=20