From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Leonid <lvasiliev@tarantool.org>, alexander.turenko@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH LUAROCKS v2 0/2] Move a rocks options filter from tarantoolctl to luarocks
Date: Wed, 18 Mar 2020 23:12:49 +0100 [thread overview]
Message-ID: <6068a76d-c4ae-a848-11fa-4e818e5c6243@tarantool.org> (raw)
In-Reply-To: <cover.1574153367.git.lvasiliev@tarantool.org>
Hi! Thanks for the patchset!
Generally the comments are the same as for the other rocks-related
patchset:
- Add a @ChangeLog;
- Provide a description of the patchset in the cover-letter. What
was made, how, why?
On 19/11/2019 09:52, Leonid wrote:
> https://github.com/tarantool/tarantool/issues/4629
> https://github.com/tarantool/luarocks/tree/lvasiliev/gh-4629-add-chdir-to-make
>
> Changes in v2:
> - Move chdir before loading the rockspec file
>
> Leonid (2):
> Add the chdir option for make
> Add the tarantool options black list. Update help
>
> src/luarocks/cmd/help.lua | 15 +++++++++------
> src/luarocks/cmd/make.lua | 22 ++++++++++++++++------
> src/luarocks/util.lua | 25 ++++++++++++++++++++-----
> 3 files changed, 45 insertions(+), 17 deletions(-)
>
next prev parent reply other threads:[~2020-03-18 22:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 8:52 Leonid
2019-11-19 8:52 ` [Tarantool-patches] [PATCH LUAROCKS v2 1/2] Add the chdir option for make Leonid
2020-03-18 22:12 ` Vladislav Shpilevoy
2019-11-19 8:52 ` [Tarantool-patches] [PATCH LUAROCKS v2 2/2] Add the tarantool options black list. Update help Leonid
2020-03-18 22:12 ` Vladislav Shpilevoy
2020-03-18 22:12 ` Vladislav Shpilevoy [this message]
2020-03-25 22:28 ` [Tarantool-patches] [PATCH LUAROCKS v2 0/2] Move a rocks options filter from tarantoolctl to luarocks lvasiliev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6068a76d-c4ae-a848-11fa-4e818e5c6243@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=lvasiliev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH LUAROCKS v2 0/2] Move a rocks options filter from tarantoolctl to luarocks' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox