From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> To: Igor Munkin <imun@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH 2/3] box: introduce port_c Date: Thu, 23 Apr 2020 02:14:56 +0200 [thread overview] Message-ID: <5fee88e7-b0ab-1423-3751-7e7e8331bac4@tarantool.org> (raw) In-Reply-To: <20200403141237.GS22874@tarantool.org> Hi! Thanks for the review! >> diff --git a/src/box/port.c b/src/box/port.c >> index 6e2fe3a6e..925a4b2d5 100644 >> --- a/src/box/port.c >> +++ b/src/box/port.c >> @@ -127,28 +132,194 @@ port_tuple_dump_msgpack(struct port *base, struct obuf *out) >> extern void >> port_tuple_dump_lua(struct port *base, struct lua_State *L, bool is_flat); >> > > <snipped> > >> + >> +static void >> +port_c_destroy(struct port *base) >> +{ >> + struct port_c *port = (struct port_c *)base; >> + struct port_c_entry *pe = port->first; >> + if (pe == NULL) >> + return; >> + port_c_destroy_entry(pe); > > Minor: It's worth to drop a few words here that the port->first points > to port->first_entry and it is released with the port_c structure. No problem: ==================== diff --git a/src/box/port.c b/src/box/port.c index 925a4b2d5..124625c7e 100644 --- a/src/box/port.c +++ b/src/box/port.c @@ -151,6 +151,11 @@ port_c_destroy(struct port *base) if (pe == NULL) return; port_c_destroy_entry(pe); + /* + * Port->first is skipped, it is pointing at + * port_c.first_entry, and is freed together with the + * port. + */ pe = pe->next; while (pe != NULL) { struct port_c_entry *cur = pe; ==================== >> + pe = pe->next; >> + while (pe != NULL) { >> + struct port_c_entry *cur = pe; >> + pe = pe->next; >> + port_c_destroy_entry(cur); >> + mempool_free(&port_entry_pool, cur); >> + } >> +} >> + > > <snipped> > >> + >> +int >> +port_c_add_mp(struct port *base, const char *mp, const char *mp_end) >> +{ >> + struct port_c *port = (struct port_c *)base; >> + struct port_c_entry *pe; >> + uint32_t size = mp_end - mp; > > Minor: since there are no guarantees except the existing contract and > common sense making this value be non-negative, I propose to add a > corresponding assert. Feel free to ignore. I don't mind. ==================== diff --git a/src/box/port.c b/src/box/port.c index 925a4b2d5..3498f7af0 100644 --- a/src/box/port.c +++ b/src/box/port.c @@ -202,6 +207,7 @@ port_c_add_mp(struct port *base, const char *mp, const char *mp_end) { struct port_c *port = (struct port_c *)base; struct port_c_entry *pe; + assert(mp_end > mp); uint32_t size = mp_end - mp; char *dst; if (size <= PORT_ENTRY_SIZE) { ====================
next prev parent reply other threads:[~2020-04-23 0:14 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-08 17:47 [Tarantool-patches] [PATCH 0/3] box_return_mp Vladislav Shpilevoy 2020-03-08 17:47 ` [Tarantool-patches] [PATCH 1/3] box: fix struct port_tuple.size wrong type in Lua Vladislav Shpilevoy 2020-03-10 13:42 ` Nikita Pettik 2020-03-11 0:17 ` Vladislav Shpilevoy 2020-03-08 17:47 ` [Tarantool-patches] [PATCH 2/3] box: introduce port_c Vladislav Shpilevoy 2020-03-26 17:49 ` Nikita Pettik 2020-04-23 0:14 ` Vladislav Shpilevoy 2020-04-27 14:09 ` Nikita Pettik 2020-04-27 21:28 ` Vladislav Shpilevoy 2020-04-27 23:24 ` Nikita Pettik 2020-04-03 14:12 ` Igor Munkin 2020-04-23 0:14 ` Vladislav Shpilevoy [this message] 2020-03-08 17:47 ` [Tarantool-patches] [PATCH 3/3] box: introduce box_return_mp() public C function Vladislav Shpilevoy 2020-03-26 17:51 ` Nikita Pettik 2020-04-03 14:13 ` Igor Munkin 2020-04-23 0:14 ` Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5fee88e7-b0ab-1423-3751-7e7e8331bac4@tarantool.org \ --to=v.shpilevoy@tarantool.org \ --cc=imun@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 2/3] box: introduce port_c' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox