From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org, Nikita Pettik <korablev@tarantool.org>
Cc: kostja@tarantool.org, Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 0/2] Introduce WITH ENGINE option for CREATE TABLE stmt
Date: Mon, 19 Aug 2019 23:05:05 +0200 [thread overview]
Message-ID: <5e4c292d-fd37-78dd-1265-4023029c5ca9@tarantool.org> (raw)
In-Reply-To: <cover.1566223966.git.korablev@tarantool.org>
Thanks for the patch! LGTM.
On 19/08/2019 16:49, Nikita Pettik wrote:
> Branch: https://github.com/tarantool/tarantool/issues/4422
> Issue: https://github.com/tarantool/tarantool/tree/np/gh-4422-with-engine-option
>
> See particular commits for details.
>
> Nikita Pettik (2):
> Do not log error in engine_find()
> sql: allow to specify engine in CREATE TABLE stmt
>
> extra/mkkeywordhash.c | 1 +
> src/box/engine.h | 4 +--
> src/box/sql/parse.y | 27 +++++++++++++--
> test/sql/engine.result | 85 ++++++++++++++++++++++++++++++++++++++++++++++++
> test/sql/engine.test.lua | 30 +++++++++++++++++
> 5 files changed, 141 insertions(+), 6 deletions(-)
>
next prev parent reply other threads:[~2019-08-19 21:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 14:49 [tarantool-patches] " Nikita Pettik
2019-08-19 14:49 ` [tarantool-patches] [PATCH 1/2] Do not log error in engine_find() Nikita Pettik
2019-08-19 14:49 ` [tarantool-patches] [PATCH 2/2] sql: allow to specify engine in CREATE TABLE stmt Nikita Pettik
2019-08-20 11:59 ` [tarantool-patches] " Konstantin Osipov
2019-08-19 21:05 ` Vladislav Shpilevoy [this message]
2019-08-20 11:57 ` [tarantool-patches] Re: [PATCH 0/2] Introduce WITH ENGINE option for " Konstantin Osipov
2019-08-20 12:10 ` n.pettik
2019-08-20 13:49 ` Konstantin Osipov
2019-08-20 13:56 ` n.pettik
2019-08-20 13:59 ` Konstantin Osipov
2019-08-22 12:07 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e4c292d-fd37-78dd-1265-4023029c5ca9@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=korablev@tarantool.org \
--cc=kostja@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 0/2] Introduce WITH ENGINE option for CREATE TABLE stmt' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox