From: Mergen Imeev via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: v.shpilevoy@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v3 14/15] sql: remove MEM_TYPE_AGG
Date: Fri, 1 Oct 2021 10:43:25 +0300 [thread overview]
Message-ID: <5e28f3760ab8e17e8dc35a6a6a48530120d69379.1633073760.git.imeevma@gmail.com> (raw)
In-Reply-To: <cover.1633073759.git.imeevma@gmail.com>
This patch removed MEM_TYPE_AGG, which is no longer used due to recent
changes.
Part of #4145
---
src/box/sql/mem.c | 25 -------------------------
src/box/sql/mem.h | 9 +--------
2 files changed, 1 insertion(+), 33 deletions(-)
diff --git a/src/box/sql/mem.c b/src/box/sql/mem.c
index e59935672..3af770f48 100644
--- a/src/box/sql/mem.c
+++ b/src/box/sql/mem.c
@@ -605,22 +605,6 @@ mem_set_frame(struct Mem *mem, struct VdbeFrame *frame)
mem->u.pFrame = frame;
}
-int
-mem_set_agg(struct Mem *mem, struct func *func, int size)
-{
- mem_clear(mem);
- if (size <= 0)
- return 0;
- if (sqlVdbeMemGrow(mem, size, 0) != 0)
- return -1;
- memset(mem->z, 0, size);
- mem->n = size;
- mem->type = MEM_TYPE_AGG;
- assert(mem->flags == 0);
- mem->u.func = func;
- return 0;
-}
-
void
mem_set_null_clear(struct Mem *mem)
{
@@ -1884,15 +1868,6 @@ mem_len(const struct Mem *mem, uint32_t *len)
return 0;
}
-int
-mem_get_agg(const struct Mem *mem, void **accum)
-{
- if (mem->type != MEM_TYPE_AGG)
- return -1;
- *accum = mem->z;
- return 0;
-}
-
int
mem_copy(struct Mem *to, const struct Mem *from)
{
diff --git a/src/box/sql/mem.h b/src/box/sql/mem.h
index c0993e573..9395f3224 100644
--- a/src/box/sql/mem.h
+++ b/src/box/sql/mem.h
@@ -54,7 +54,6 @@ enum mem_type {
MEM_TYPE_INVALID = 1 << 11,
MEM_TYPE_FRAME = 1 << 12,
MEM_TYPE_PTR = 1 << 13,
- MEM_TYPE_AGG = 1 << 14,
};
/*
@@ -187,12 +186,6 @@ mem_is_array(const struct Mem *mem)
return mem->type == MEM_TYPE_ARRAY;
}
-static inline bool
-mem_is_agg(const struct Mem *mem)
-{
- return mem->type == MEM_TYPE_AGG;
-}
-
static inline bool
mem_is_bytes(const struct Mem *mem)
{
@@ -967,7 +960,7 @@ int sqlVdbeMemTooBig(Mem *);
* that needs to be deallocated to avoid a leak.
*/
#define VdbeMemDynamic(X) (((X)->flags & MEM_Dyn) != 0 ||\
- ((X)->type & (MEM_TYPE_AGG | MEM_TYPE_FRAME)) != 0)
+ ((X)->type & MEM_TYPE_FRAME) != 0)
/**
* Perform comparison of two tuples: unpacked (key1) and packed (key2)
--
2.25.1
next prev parent reply other threads:[~2021-10-01 7:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 7:42 [Tarantool-patches] [PATCH v3 00/15] sql: refactor aggregate functions Mergen Imeev via Tarantool-patches
2021-10-01 7:42 ` [Tarantool-patches] [PATCH v3 01/15] sql: fix possible undefined behavior during cast Mergen Imeev via Tarantool-patches
2021-10-01 7:42 ` [Tarantool-patches] [PATCH v3 02/15] sql: use register P1 for number of arguments Mergen Imeev via Tarantool-patches
2021-10-01 7:42 ` [Tarantool-patches] [PATCH v3 03/15] sql: remove AggStep0 and OP_BuiltinFunction0 Mergen Imeev via Tarantool-patches
2021-10-01 7:42 ` [Tarantool-patches] [PATCH v3 04/15] sql: move collation to struct sql_context Mergen Imeev via Tarantool-patches
2021-10-01 7:42 ` [Tarantool-patches] [PATCH v3 05/15] sql: introduce mem_append() Mergen Imeev via Tarantool-patches
2021-10-01 7:42 ` [Tarantool-patches] [PATCH v3 06/15] sql: remove sql_vdbemem_finalize() Mergen Imeev via Tarantool-patches
2021-10-01 7:42 ` [Tarantool-patches] [PATCH v3 07/15] sql: refactor SUM() function Mergen Imeev via Tarantool-patches
2021-10-01 7:43 ` [Tarantool-patches] [PATCH v3 08/15] sql: refactor TOTAL() function Mergen Imeev via Tarantool-patches
2021-10-01 7:43 ` [Tarantool-patches] [PATCH v3 09/15] sql: refactor AVG() function Mergen Imeev via Tarantool-patches
2021-10-01 7:43 ` [Tarantool-patches] [PATCH v3 10/15] sql: refactor COUNT() function Mergen Imeev via Tarantool-patches
2021-10-01 7:43 ` [Tarantool-patches] [PATCH v3 11/15] sql: refactor MIN() and MAX() functions Mergen Imeev via Tarantool-patches
2021-10-01 7:43 ` [Tarantool-patches] [PATCH v3 12/15] sql: refactor GROUP_CONCAT() function Mergen Imeev via Tarantool-patches
2021-10-01 7:43 ` [Tarantool-patches] [PATCH v3 13/15] sql: remove copying of result in finalizers Mergen Imeev via Tarantool-patches
2021-10-01 7:43 ` Mergen Imeev via Tarantool-patches [this message]
2021-10-01 7:43 ` [Tarantool-patches] [PATCH v3 15/15] sql: remove field argv from struct sql_context Mergen Imeev via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e28f3760ab8e17e8dc35a6a6a48530120d69379.1633073760.git.imeevma@gmail.com \
--to=tarantool-patches@dev.tarantool.org \
--cc=imeevma@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3 14/15] sql: remove MEM_TYPE_AGG' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox