From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Roman Khabibov <roman.habibov@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 0/2] Name columns in a different way
Date: Fri, 1 May 2020 21:35:56 +0200 [thread overview]
Message-ID: <5dd7c06e-0b26-6bcd-a173-23c5e7d7d660@tarantool.org> (raw)
In-Reply-To: <20200426230900.23258-1-roman.habibov@tarantool.org>
Thanks for the patchset!
On 27/04/2020 01:08, Roman Khabibov wrote:
> Should I squash these patches into one patch?
They close different bugs, so I would keep them separate.
> Branch: https://github.com/tarantool/tarantool/tree/romanhabibov/gh-3962-column
> Issue: https://github.com/tarantool/tarantool/issues/3962
> Issue: https://github.com/tarantool/tarantool/issues/4545
>
> @ChangeLog:
> - Name auto generated columns as “COLUMN_N” instead of “_auto_name_”
> or span of the original expression.
> - Don't make column names unique by printing "_1" to the end during
> <FROM> processing.
Please, write 'Changes in v<patch_version>' changelog about what
has changed in a major way since previous version of the patch. It
helps a lot, when I return to the patch after a long time.
next prev parent reply other threads:[~2020-05-01 19:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200426230900.23258-1-roman.habibov@tarantool.org>
2020-04-26 23:09 ` [Tarantool-patches] [PATCH v2 2/2] sql: don't modify column names Roman Khabibov
2020-05-01 19:39 ` Vladislav Shpilevoy
2020-05-01 19:35 ` Vladislav Shpilevoy [this message]
[not found] ` <20200426230900.23258-2-roman.habibov@tarantool.org>
2020-05-01 19:37 ` [Tarantool-patches] [PATCH v2 1/2] sql: use unify pattern for " Vladislav Shpilevoy
2020-06-11 14:58 ` Roman Khabibov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dd7c06e-0b26-6bcd-a173-23c5e7d7d660@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=roman.habibov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 0/2] Name columns in a different way' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox