From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org,
Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] [PATCH v2 1/2] Fixed invalid check in lbox_tuple_transform.
Date: Fri, 6 Apr 2018 19:24:41 +0300 [thread overview]
Message-ID: <5d4367fda9fdbb98d9c34b1a001e6f867f617bc2.1523031806.git.kshcherbatov@tarantool.org> (raw)
In-Reply-To: <cover.1523031806.git.kshcherbatov@tarantool.org>
In-Reply-To: <cover.1523031806.git.kshcherbatov@tarantool.org>
Tuple has been checked instead of new_tuple returned as box_tuple_update result.
---
src/box/lua/tuple.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/box/lua/tuple.c b/src/box/lua/tuple.c
index 7ca4299..47b33c9 100644
--- a/src/box/lua/tuple.c
+++ b/src/box/lua/tuple.c
@@ -393,7 +393,7 @@ lbox_tuple_transform(struct lua_State *L)
/* Execute tuple_update */
struct tuple *new_tuple =
box_tuple_update(tuple, buf->buf, buf->buf + ibuf_used(buf));
- if (tuple == NULL)
+ if (new_tuple == NULL)
luaT_error(L);
/* box_tuple_update() doesn't leak on exception, see public API doc */
luaT_pushtuple(L, new_tuple);
--
2.7.4
next prev parent reply other threads:[~2018-04-06 16:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-06 16:24 [tarantool-patches] [PATCH v2 0/2] Fix lost format on update operation Kirill Shcherbatov
2018-04-06 16:24 ` Kirill Shcherbatov [this message]
2018-04-06 16:24 ` [tarantool-patches] [PATCH v2 2/2] Fixed lost format on update and upsert operations Kirill Shcherbatov
2018-04-08 13:56 ` [tarantool-patches] " Vladislav Shpilevoy
2018-04-10 10:23 ` Kirill Shcherbatov
2018-04-10 10:44 ` Vladislav Shpilevoy
2018-04-15 10:03 ` Kirill Shcherbatov
2018-04-15 13:18 ` Vladislav Shpilevoy
2018-04-16 7:47 ` Kirill Shcherbatov
2018-04-16 10:07 ` Vladislav Shpilevoy
2018-04-16 16:51 ` Kirill Shcherbatov
2018-04-16 17:14 ` Vladislav Shpilevoy
2018-04-18 12:28 ` Vladimir Davydov
2018-04-18 12:55 ` Kirill Shcherbatov
2018-04-22 15:15 ` Vladislav Shpilevoy
2018-04-28 6:56 ` Kirill Shcherbatov
2018-04-28 9:29 ` [tarantool-patches] Re: [PATCH v2 0/2] Fix lost format on update operation Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d4367fda9fdbb98d9c34b1a001e6f867f617bc2.1523031806.git.kshcherbatov@tarantool.org \
--to=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [tarantool-patches] [PATCH v2 1/2] Fixed invalid check in lbox_tuple_transform.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox