[tarantool-patches] Re: [PATCH v6 0/7] sql: set column types for EXPLAIN and PRAGMA

[Imeev Mergen <imeevma@tarantool.org>]

Hi! Thank you for review!

On 2/25/19 2:59 PM, Vladislav Shpilevoy wrote:
> Hi! Thanks for the fixes!
>
> On 21/02/2019 16:00, imeevma@tarantool.org wrote:
>> This patch-set defines the types for the result columns of EXPLAIN
>> and PRAGMA commands. In addition, it fixes some problems of the
>> PRAGMA commands that have something to do with their result.
>>
>> https://github.com/tarantool/tarantool/issues/3832
>> https://github.com/tarantool/tarantool/tree/imeevma/gh-3832-no-column-types 
>>
>>
>> Changes in sixth version:
>>    - Rebase to current 2.1
>>    - New patch that removes gh-3733-pragma.test.lua
>>    - Other small fixes.
>
> Neither of these things are worth sending new patches in a
> new thread with a bumped version. Please, next time try to
> keep the discussion in the same thread if no drastic changes.
>
> The patchset is good now.
>
> Now, please, add docbot request to the last commit,
> describing changes in PRAGMA output. Including all the
> previous commits too. I mean, that 'PRAGMA' now returns
> name/value pairs, how now 'EXPLAIN' works, that
> 'sql_default_engine' and 'case_sensitive_like' return a
> current value, what does 'parser_trace', etc.
>
> Do not resend a new version. Just add a docbot request,
> signal here about it, and I will say LGTM.
Fixed, added a docbot request and rebased to current 2.1.