From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org,
Konstantin Osipov <kostja@tarantool.org>
Cc: vdavydov.dev@gmail.com
Subject: Re: [tarantool-patches] Re: [PATCH 0/4] Outdate disconnected session
Date: Tue, 11 Dec 2018 19:12:37 +0300 [thread overview]
Message-ID: <5c514703-945c-f34c-0100-a256d0ec23f0@tarantool.org> (raw)
In-Reply-To: <20181207173541.GB840@chai>
On 07/12/2018 20:35, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [18/12/07 18:48]:
>> Once a connection is closed, a long-running user request can not
>> learn about this occasion. Even box.sesion.push() still works and
>> on_disconnect triggers are not run.
>>
>> This patch makes things simpler:
>>
>> * disconnected session is marked as dead. So a user can determine
>> if a connection is closed by looking at session type == 'dead',
>> or checking for errors from box.session.push();
>
> 'dead' is not a session type, it's session state. Please add a
> separate method for this purpose, and not abuse the type.
Done. See v2.
>>
>> * on_disconnect triggers are run right after disconnect. Even if
>> there are some active requests.
>
> This is an incompatible change. But people have been actually
> complaining in the chat that disconnect triggers are only run
> after all messages are processed. So a good one.
>
>
next prev parent reply other threads:[~2018-12-11 16:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 15:46 Vladislav Shpilevoy
2018-12-07 15:46 ` [PATCH 1/4] iproto: rename disconnect cmsg to destroy Vladislav Shpilevoy
2018-12-07 17:36 ` [tarantool-patches] " Konstantin Osipov
2018-12-11 12:54 ` [tarantool-patches] " Vladislav Shpilevoy
2018-12-07 15:46 ` [PATCH 2/4] iproto: fire on_disconnect right after disconnect Vladislav Shpilevoy
2018-12-07 17:37 ` [tarantool-patches] " Konstantin Osipov
2018-12-11 12:55 ` [tarantool-patches] " Vladislav Shpilevoy
2018-12-07 15:46 ` [PATCH 3/4] session: introduce 'dead' type Vladislav Shpilevoy
2018-12-07 17:38 ` [tarantool-patches] " Konstantin Osipov
2018-12-07 20:40 ` [tarantool-patches] " Vladislav Shpilevoy
2018-12-07 22:21 ` Konstantin Osipov
2018-12-07 22:42 ` Vladislav Shpilevoy
2018-12-07 15:46 ` [PATCH 4/4] session: kill a session of a closed connection Vladislav Shpilevoy
2018-12-07 17:35 ` [tarantool-patches] [PATCH 0/4] Outdate disconnected session Konstantin Osipov
2018-12-11 16:12 ` Vladislav Shpilevoy [this message]
2018-12-07 17:41 ` Konstantin Osipov
2018-12-11 16:13 ` [tarantool-patches] " Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c514703-945c-f34c-0100-a256d0ec23f0@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [tarantool-patches] Re: [PATCH 0/4] Outdate disconnected session' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox