From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 4/5] sql: make built-ins raise errors for varbin args
Date: Fri, 26 Jul 2019 00:11:53 +0200 [thread overview]
Message-ID: <5bb71271-27ea-423b-ed27-634ba7a2c132@tarantool.org> (raw)
In-Reply-To: <61adf9b0d2ce82a927f318c386dd0a004eb3ca45.1563967510.git.korablev@tarantool.org>
On 24/07/2019 13:42, Nikita Pettik wrote:
> Since values of type 'varbinary' can't be cast to any other type, let's
> patch built-in functions which are not assumed to accept arguments of
> this type to raise an error in case argument turn out to be of type
> varbinary.
>
> Part of #4206
> ---
> src/box/sql/func.c | 24 ++++++++++++++++++++++--
> 1 file changed, 22 insertions(+), 2 deletions(-)
>
> diff --git a/src/box/sql/func.c b/src/box/sql/func.c
> index 4ec591eee..5fd1496fd 100644
> --- a/src/box/sql/func.c
> +++ b/src/box/sql/func.c
> @@ -506,6 +507,12 @@ roundFunc(sql_context * context, int argc, sql_value ** argv)
> }
> if (sql_value_is_null(argv[0]))
> return;
> + if (sql_value_type(argv[0]) == MP_BIN) {
> + diag_set(ClientError, ER_SQL_TYPE_MISMATCH,
The patch is ok, but now I see, that we allow 'string' values to functions,
taking numbers, such as round(). Is it ok?
next prev parent reply other threads:[~2019-07-25 22:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 11:42 [tarantool-patches] [PATCH 0/5] Introduce VARBINARY in SQL Nikita Pettik
2019-07-24 11:42 ` [tarantool-patches] [PATCH 1/5] sql: always erase numeric flag after stringifying Nikita Pettik
2019-07-24 11:42 ` [tarantool-patches] [PATCH 2/5] sql: fix resulting type calculation for CASE-WHEN stmt Nikita Pettik
2019-07-25 22:12 ` [tarantool-patches] " Vladislav Shpilevoy
[not found] ` <a061e845-eeb1-00d1-9141-3b9bb87768f5@tarantool.org>
2019-07-28 23:56 ` n.pettik
2019-07-24 11:42 ` [tarantool-patches] [PATCH 3/5] sql: use 'varbinary' as a name of type instead of 'blob' Nikita Pettik
2019-07-25 22:11 ` [tarantool-patches] " Vladislav Shpilevoy
[not found] ` <2e655514-0fec-8baf-20a8-d49e5586b047@tarantool.org>
2019-07-28 23:56 ` n.pettik
2019-07-29 21:03 ` Vladislav Shpilevoy
2019-07-30 13:43 ` n.pettik
2019-07-24 11:42 ` [tarantool-patches] [PATCH 4/5] sql: make built-ins raise errors for varbin args Nikita Pettik
2019-07-25 22:11 ` Vladislav Shpilevoy [this message]
[not found] ` <05d15035-2552-1f05-b7ce-facfbbc3a520@tarantool.org>
2019-07-28 23:59 ` [tarantool-patches] " n.pettik
2019-07-24 11:42 ` [tarantool-patches] [PATCH 5/5] sql: introduce VARBINARY column type Nikita Pettik
2019-07-25 22:12 ` [tarantool-patches] " Vladislav Shpilevoy
[not found] ` <49a188eb-dafe-44e7-a0fd-e9244b68e721@tarantool.org>
2019-07-29 0:03 ` n.pettik
2019-07-29 20:55 ` Vladislav Shpilevoy
2019-07-30 13:44 ` n.pettik
2019-07-30 19:41 ` Vladislav Shpilevoy
2019-07-30 19:52 ` Vladislav Shpilevoy
2019-07-31 14:51 ` n.pettik
2019-08-01 8:42 ` [tarantool-patches] Re: [PATCH 0/5] Introduce VARBINARY in SQL Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bb71271-27ea-423b-ed27-634ba7a2c132@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 4/5] sql: make built-ins raise errors for varbin args' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox