From: Sergey Bronnikov <sergeyb@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1] replication: change space sync mode in a loop
Date: Tue, 1 Sep 2020 15:50:15 +0300 [thread overview]
Message-ID: <5a15dbd9-f362-011a-d494-d6ba75e81be7@tarantool.org> (raw)
In-Reply-To: <6478b29b-ccee-35c5-665a-628c9e50b0b1@tarantool.org>
Hi, thanks for review!
On 01.09.2020 15:25, Serge Petrenko wrote:
>> I have rewrote tests to consider to cases:
>> - positive, when we have achievable quorum, set mode to sync or async
>> on a master
>> and then make an insert. Expected successful writes always.
>> - negative, when we change mode to sync or async with tx's in a limbo.
>>
>> So comment above is not relevant now.
>
> Hi! Thanks for the fixes.
>
> The negative case seems pointless, since the change won't happen until
> the limbo
> gets emptied out. This is because alter{is_sync=...} is a DML
> operation which
> replaces an entry in _space system space, so it gets stuck on a
> non-empty limbo,
> just like any DML op.
Yes, I had doubts regarding this testcase despite I know about such
behavior.
> I suggest you remove it altogether.
Well, negative testcase removed.
>
> Other than that LGTM.
>
>
next prev parent reply other threads:[~2020-09-01 12:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 15:10 sergeyb
2020-08-27 11:27 ` Sergey Petrenko
2020-08-31 11:06 ` Sergey Bronnikov
2020-09-01 12:25 ` Serge Petrenko
2020-09-01 12:50 ` Sergey Bronnikov [this message]
2020-11-12 9:27 ` Sergey Bronnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a15dbd9-f362-011a-d494-d6ba75e81be7@tarantool.org \
--to=sergeyb@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1] replication: change space sync mode in a loop' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox