Tarantool development patches archive
 help / color / mirror / Atom feed
From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: ban ANALYZE statement
Date: Fri, 22 Mar 2019 19:58:13 +0300	[thread overview]
Message-ID: <5B3DB7B4-92A8-40B5-91F3-6A74B431652A@tarantool.org> (raw)
In-Reply-To: <a417f035ec8526467e241ab258fb818e2df906b5.1553271184.git.imeevma@gmail.com>


> /////////////////////////////////// ANALYZE ///////////////////////////////////
> -cmd ::= ANALYZE.                {sqlAnalyze(pParse, 0);}
> -cmd ::= ANALYZE nm(X).          {sqlAnalyze(pParse, &X);}
> +cmd ::= ANALYZE.                {}
> +cmd ::= ANALYZE nm(X).          {(void)X;}

Could you remove this statement from parser?
Since it does nothing, it may turn out to be confusing.

  reply	other threads:[~2019-03-22 16:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-22 16:14 [tarantool-patches] " imeevma
2019-03-22 16:58 ` n.pettik [this message]
2019-03-23 12:58   ` [tarantool-patches] " Mergen Imeev
2019-03-23 19:13     ` n.pettik
2019-03-25 16:30       ` Imeev Mergen
2019-03-26 10:27 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5B3DB7B4-92A8-40B5-91F3-6A74B431652A@tarantool.org \
    --to=korablev@tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v1 1/1] sql: ban ANALYZE statement' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox