From: Serge Petrenko <sergepetrenko@tarantool.org>
To: Konstantin Osipov <kostja.osipov@gmail.com>,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3 2/4] recovery: allow to ignore rows coming from a certain instance
Date: Wed, 19 Feb 2020 13:31:40 +0300 [thread overview]
Message-ID: <5AFD65D5-F667-4632-8151-17A123558EDA@tarantool.org> (raw)
In-Reply-To: <20200219101141.GA9945@atlas>
> 19 февр. 2020 г., в 13:11, Konstantin Osipov <kostja.osipov@gmail.com> написал(а):
>
> * Serge Petrenko <sergepetrenko@tarantool.org> [20/02/19 12:36]:
>> I mean taking replica clock from a subscribe request and setting replica_clock[replica->id] = INT64_MAX.
>> This is done on master in relay_subscribe() called from box_process_subscribe(). Then relay recovery is initialized
>> with this vclock making recovery skip rows coming from the replica itself.
>
> Why is this logic done on master? Why can't you send the right
> vclock from replica?
>
Cos this strange vclock will be used to initialize gc consumer,
and this gc consumer will be ordered by that vclock signature,
which will overflow.
Anyway, let me send the patch first. This is the same problem
in both cases, when the logic you propose works either on master or
on replica side.
--
Serge Petrenko
sergepetrenko@tarantool.org
>
> --
> Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2020-02-19 10:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 17:37 [Tarantool-patches] [PATCH v3 0/4] replication: fix applying of rows originating from local instance Serge Petrenko
2020-02-18 17:37 ` [Tarantool-patches] [PATCH v3 1/4] box: expose box_is_orphan method Serge Petrenko
2020-02-18 17:37 ` [Tarantool-patches] [PATCH v3 2/4] recovery: allow to ignore rows coming from a certain instance Serge Petrenko
2020-02-18 19:03 ` Konstantin Osipov
2020-02-19 8:43 ` Serge Petrenko
2020-02-19 8:52 ` Konstantin Osipov
2020-02-19 8:57 ` Serge Petrenko
2020-02-19 9:02 ` Konstantin Osipov
2020-02-19 9:35 ` Serge Petrenko
2020-02-19 10:11 ` Konstantin Osipov
2020-02-19 10:31 ` Serge Petrenko [this message]
2020-02-19 11:27 ` Konstantin Osipov
2020-02-18 17:37 ` [Tarantool-patches] [PATCH v3 3/4] replication: do not relay rows coming from a remote instance back to it Serge Petrenko
2020-02-18 19:07 ` Konstantin Osipov
2020-02-18 17:37 ` [Tarantool-patches] [PATCH v3 4/4] wal: warn when trying to write a record with a broken lsn Serge Petrenko
2020-02-22 20:21 ` [Tarantool-patches] [PATCH v3 0/4] replication: fix applying of rows originating from local instance Georgy Kirichenko
2020-02-22 20:49 ` Konstantin Osipov
2020-02-23 8:16 ` Georgy Kirichenko
2020-02-24 10:18 ` Konstantin Osipov
2020-02-24 12:31 ` Георгий Кириченко
2020-02-26 10:09 ` Sergey Petrenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5AFD65D5-F667-4632-8151-17A123558EDA@tarantool.org \
--to=sergepetrenko@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3 2/4] recovery: allow to ignore rows coming from a certain instance' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox