Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@dev.tarantool.org, avtikhon@tarantool.org
Subject: [Tarantool-patches] [PATCH 4/4] test: fix flaky qsync_basic.test.lua
Date: Thu, 16 Jul 2020 22:38:13 +0200	[thread overview]
Message-ID: <589b7e99d1e67d512bf166bf6b41262fff56d357.1594931843.git.v.shpilevoy@tarantool.org> (raw)
In-Reply-To: <cover.1594931843.git.v.shpilevoy@tarantool.org>

Too small timeouts were used for testing that synchronous
transactions succeed.

Follow-up #5162
---
 test/replication/qsync_basic.result   | 6 +++---
 test/replication/qsync_basic.test.lua | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/test/replication/qsync_basic.result b/test/replication/qsync_basic.result
index b355a5c06..bd3c3cce1 100644
--- a/test/replication/qsync_basic.result
+++ b/test/replication/qsync_basic.result
@@ -96,7 +96,7 @@ old_synchro_quorum = box.cfg.replication_synchro_quorum
 old_synchro_timeout = box.cfg.replication_synchro_timeout
  | ---
  | ...
-box.cfg{replication_synchro_quorum=2, replication_synchro_timeout=0.1}
+box.cfg{replication_synchro_quorum = 2, replication_synchro_timeout = 1000}
  | ---
  | ...
 
@@ -130,7 +130,7 @@ box.info.lsn - lsn
  | - 2
  | ...
 -- Raise quorum so that master has to issue a ROLLBACK.
-box.cfg{replication_synchro_quorum=3}
+box.cfg{replication_synchro_quorum = 3, replication_synchro_timeout = 0.001}
  | ---
  | ...
 t = fiber.time()
@@ -145,7 +145,7 @@ fiber.time() - t > box.cfg.replication_synchro_timeout
  | ---
  | - true
  | ...
-box.cfg{replication_synchro_quorum=2}
+box.cfg{replication_synchro_quorum = 2, replication_synchro_timeout = 1000}
  | ---
  | ...
 box.space.sync:insert{3}
diff --git a/test/replication/qsync_basic.test.lua b/test/replication/qsync_basic.test.lua
index 205fb0664..94235547d 100644
--- a/test/replication/qsync_basic.test.lua
+++ b/test/replication/qsync_basic.test.lua
@@ -40,7 +40,7 @@ box.schema.user.grant('guest', 'replication')
 -- Set up synchronous replication options.
 old_synchro_quorum = box.cfg.replication_synchro_quorum
 old_synchro_timeout = box.cfg.replication_synchro_timeout
-box.cfg{replication_synchro_quorum=2, replication_synchro_timeout=0.1}
+box.cfg{replication_synchro_quorum = 2, replication_synchro_timeout = 1000}
 
 test_run:cmd('create server replica with rpl_master=default,\
                                          script="replication/replica.lua"')
@@ -54,12 +54,12 @@ box.space.sync:insert{1}
 -- 1 for insertion, 1 for CONFIRM message.
 box.info.lsn - lsn
 -- Raise quorum so that master has to issue a ROLLBACK.
-box.cfg{replication_synchro_quorum=3}
+box.cfg{replication_synchro_quorum = 3, replication_synchro_timeout = 0.001}
 t = fiber.time()
 box.space.sync:insert{2}
 -- Check that master waited for acks.
 fiber.time() - t > box.cfg.replication_synchro_timeout
-box.cfg{replication_synchro_quorum=2}
+box.cfg{replication_synchro_quorum = 2, replication_synchro_timeout = 1000}
 box.space.sync:insert{3}
 box.space.sync:select{}
 
-- 
2.21.1 (Apple Git-122.3)

  parent reply	other threads:[~2020-07-16 20:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-16 20:38 [Tarantool-patches] [PATCH 0/4] Flaky qsync tests Vladislav Shpilevoy
2020-07-16 20:38 ` [Tarantool-patches] [PATCH 1/4] test: fix flaky qsync_with_anon.test.lua Vladislav Shpilevoy
2020-07-16 20:38 ` [Tarantool-patches] [PATCH 2/4] test: fix flaky qsync_advanced.test.lua Vladislav Shpilevoy
2020-07-16 20:38 ` [Tarantool-patches] [PATCH 3/4] test: fix flaky qsync_snapshots.test.lua Vladislav Shpilevoy
2020-07-16 20:38 ` Vladislav Shpilevoy [this message]
2020-07-17 13:19 ` [Tarantool-patches] [PATCH 0/4] Flaky qsync tests Alexander V. Tikhonov
2020-07-20 19:23   ` Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=589b7e99d1e67d512bf166bf6b41262fff56d357.1594931843.git.v.shpilevoy@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=avtikhon@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 4/4] test: fix flaky qsync_basic.test.lua' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox