From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> To: Serge Petrenko <sergepetrenko@tarantool.org>, gorcunov@gmail.com Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH] replication: remove unnecessary errors on replicating from an anonymous instance Date: Wed, 6 May 2020 23:51:19 +0200 [thread overview] Message-ID: <586c95c1-8bec-8205-402b-24c07ebf603d@tarantool.org> (raw) In-Reply-To: <7cc455cc-185f-b4cb-17bb-13e3528c63c0@tarantool.org> Hi! Thanks for the fixes! See 2 keyboard-related nits below. Everything else LGTM. > diff --git a/test/replication/anon.result b/test/replication/anon.result > index 997112c84..8782212ca 100644 > --- a/test/replication/anon.result > +++ b/test/replication/anon.result > @@ -366,9 +367,9 @@ test_run:cmd('switch replica_anon2') > | --- > | - true > | ... > -box.space.test:select{} > +test_run:wait_cond(function() return box.space.test:get{1} ~= nil end, 10) 1. :) Double whitespace after '~= nil'. > | --- > - | - - [1] > + | - true > | ... > @@ -429,36 +430,10 @@ test_run:cmd('set variable repl_source to "replica_anon1.listen"') > box.cfg{replication=repl_source} > | --- > | ... > - > -test_run:cmd('switch default') > - | --- > - | - true > - | ... > -box.space.test:insert{2} > - | --- > - | - [2] > - | ... > - > -test_run:cmd('switch replica_anon1') > - | --- > - | - true > - | ... > --- Check that the new replica follows an anonymous one. > -test_run:wait_downstream(2, {status='follow'}) > +test_run:wait_log('replica', 'ER_UNSUPPORTED: Anonymous replica does not support non.anonymous followers.', nil, 10) 2. Perhaps 'non-anonymous' instead of 'non.anonymous'?
next prev parent reply other threads:[~2020-05-06 21:51 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-20 13:11 Serge Petrenko 2020-04-20 19:29 ` Cyrill Gorcunov 2020-04-28 20:55 ` Vladislav Shpilevoy 2020-05-06 10:08 ` Serge Petrenko 2020-05-06 21:51 ` Vladislav Shpilevoy [this message] 2020-05-07 10:33 ` Serge Petrenko 2020-05-07 21:53 ` Vladislav Shpilevoy 2020-05-08 11:16 ` Serge Petrenko 2020-05-10 19:43 ` Vladislav Shpilevoy 2020-05-15 14:37 ` Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=586c95c1-8bec-8205-402b-24c07ebf603d@tarantool.org \ --to=v.shpilevoy@tarantool.org \ --cc=gorcunov@gmail.com \ --cc=sergepetrenko@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH] replication: remove unnecessary errors on replicating from an anonymous instance' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox